[wasm][aot] Reenable AOT System.Runtime.Intrinsics/tests and fix problems that exposed #115204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the crashing tests are in the range disabled by 2745546 I haven't narrowed it down more than that yet |
|
The swizzle change has the potential to cause regressions, if it does I believe I can fix them but I would like to get benchmarks on this version first |
|
Tagging subscribers to 'arch-wasm': @lewing |
radekdoulik
approved these changes
May 5, 2025
|
/ba-g changes are only in wasm paths, other failures are not related |
Open
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable System.Runtime.Intrinsics/tests in wasm smoke tests then fix the Shuffle intrinsics crash the tests exposed. See #115062 for details.
The crash would happen when a non-constant index vector was passed to the llvm shuffle intrinsic which was exposed when the ShuffleNative path was added to the tests. The PR works around it by using the swizzle intrinsic which does not require a const index vector. If this does cause a regression it we should be able to restore the original implementation when we can verify a constant index vector is being passed.
This also fixes the PackedSimd.Min/Max intrinsic implementation which had accidentally reversed min and max.
Fixes #115203