Clean up stale debugger-related surface area in ThreadPool and Task{Scheduler} #115210
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up obsolete debugger-related properties that are no longer used by the VS debugger team. The changes remove the AllTimers property from Timer.cs, the RequiresAtomicStartTransition property from ThreadPoolTaskScheduler.cs, and two debugger-only properties (StateFlagsForDebugger and StateFlags) from Task.cs.
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Timer.cs | Removed the AllTimers property used solely for debugger inspection. |
| ThreadPoolTaskScheduler.cs | Removed the RequiresAtomicStartTransition property no longer needed. |
| Task.cs | Removed debugger-only properties StateFlagsForDebugger and StateFlags. |
Files not reviewed (1)
- src/libraries/System.Private.CoreLib/src/ILLink/ILLink.Descriptors.Shared.xml: Language not supported
| @@ -973,23 +973,5 @@ public ValueTask DisposeAsync() | |||
| } | |||
|
|
|||
| private string DisplayString => _timer._timer.DisplayString; | |||
|
|
|||
| /// <summary>Gets a list of all timers for debugging purposes.</summary> | |||
| private static IEnumerable<TimerQueueTimer> AllTimers // intended to be used by devs from debugger | |||
There was a problem hiding this comment.
If memory serves (and the comment confirms), this wasn't used by the debugger itself but rather intended to be used by a developer in the debugger, e.g. in a watch window. It was added in #49100.
That said, I've not used this in years, I suspect few others have either, it's not documented, etc. I'd be fine removing it.
|
/ba-g unrelated error |
After checking with the VS debugger team, seems like it should be safe to remove these properties, other fields/properties/methods seem to still be in use.
Fixes #62653.