Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove ymm embedded rounding from AVX10.2 #115235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove ymm embedded rounding from AVX10.2 #115235

wants to merge 1 commit into from
+18 −553

Conversation

khushal1996
Copy link
Member

@khushal1996 khushal1996 commented May 2, 2025 •
edited
Loading

This PR reverts the YMM enbedded rounding introduced in .NET for AVX10.2 hardware. addresses #115060. This change was introduced in #111209

Breaking change doc - dotnet/docs#46000

Testing

Emitter tests and superpmi tests not needed since we are removing APIs here.

SDE tests
Avx10.2 disabled
image

Avx10.2 enabled
image

@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
@dotnet-issue-labeler dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label May 2, 2025
This was referenced May 2, 2025
Open
Open
@khushal1996 khushal1996 marked this pull request as ready for review May 2, 2025 10:02
@Copilot Copilot AI review requested due to automatic review settings May 2, 2025 10:02
Copilot
Copilot AI reviewed May 2, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes support for YMM embedded rounding for AVX10.2 by reverting the APIs and intrinsic cases that were introduced for rounding modes. Key changes include:

  • Removal of intrinsic templates and test cases that relied on embedded rounding.
  • Removal of API overloads with rounding mode parameters from the runtime intrinsics and corresponding platform not supported stubs.
  • Updates to the JIT and emitter code to eliminate handling of the YMM embedded rounding bit.

Reviewed Changes

Copilot reviewed 7 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/tests/Common/GenerateHWIntrinsicTests/GenerateHWIntrinsicTests_X86.cs Removed embedded rounding test templates.
src/libraries/System.Runtime.Intrinsics/ref/System.Runtime.Intrinsics.cs Removed rounding-mode overloads for AVX10v2 intrinsics.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/X86/Avx10v2.cs Eliminated rounding-related overloads and comments.
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/X86/Avx10v2.PlatformNotSupported.cs Removed rounding-related stubs.
src/coreclr/jit/hwintrinsiclistxarch.h Updated intrinsic registration definitions to remove embedded rounding intrinsics.
src/coreclr/jit/gentree.cpp Removed case statements for embedded rounding intrinsics.
src/coreclr/jit/emitxarch.cpp Removed uBIT constant and related handling for embedded rounding.
Files not reviewed (2)
  • src/tests/JIT/HardwareIntrinsics/X86/Shared/SimpleBinOpEmbRounding.template: Language not supported
  • src/tests/JIT/HardwareIntrinsics/X86/Shared/SimpleUnaryOpEmbRounding.template: Language not supported

@tannergooding
Copy link
Member

CC. @dotnet/jit-contrib, @EgorBo for secondary review

@khushal1996
Copy link
Member Author

khushal1996 commented May 2, 2025 •
edited
Loading

breaking-change

@tannergooding tannergooding added breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet labels May 2, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Added needs-breaking-change-doc-created label because this PR has the breaking-change label.

When you commit this breaking change:

  1. Create and link to this PR and the issue a matching issue in the dotnet/docs repo using the breaking change documentation template, then remove this needs-breaking-change-doc-created label.
  2. Ask a committer to mail the .NET Breaking Change Notification DL.

Tagging @dotnet/compat for awareness of the breaking change.

@tannergooding
Copy link
Member

We just need to open an issue describing the break (or rather functional change from prerelease) using https://github.com/dotnet/docs/issues/new?template=02-breaking-change.yml

@tannergooding
Copy link
Member

Will merge once the breaking change doc has been created.

@khushal1996 khushal1996 mentioned this pull request May 2, 2025
Open
3 tasks
@khushal1996
Copy link
Member Author

Will merge once the breaking change doc has been created.

Breaking change issue - dotnet/docs#46000

@tannergooding
Copy link
Member

Looks like conflicts from one of the other PRs that got merged

@khushal1996 khushal1996 force-pushed the kcm-avx102-revert-public-pr branch from 80e2bc0 to 384a720 Compare May 5, 2025 21:29
@khushal1996
Copy link
Member Author

Looks like conflicts from one of the other PRs that got merged

resolved the merge conflicts and ran the tests again. LGTM

This was referenced May 6, 2025
Open
Open
Open
Open
Open
@build-analysis build-analysis bot mentioned this pull request May 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@EgorBo EgorBo EgorBo approved these changes

@tannergooding tannergooding tannergooding approved these changes

Assignees
No one assigned
Labels
area-System.Runtime.Intrinsics breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. community-contribution Indicates that the PR has been added by a community member needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khushal1996 @tannergooding @EgorBo