[wasm] Always respect WasmEnableSIMD when trimming #115313
Draft
+19
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewing
commented
May 5, 2025
| @@ -325,7 +325,7 @@ mono_wasm_load_runtime_common (int debug_level, MonoLogCallback log_callback, co | |||
| */ | |||
| if (debug_level) { | |||
| // Disable optimizations which interfere with debugging | |||
| interp_opts = "-all"; | |||
| interp_opts = "-all,simd"; | |||
There was a problem hiding this comment.
This keeps simd intrinsics live when debugging otherwise we'd trim PackedSimd.IsSupported to true but it would fail at runtime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always respect WasmEnableSIMD and keep simd intrinsics live when configuration=Debug and WasmEnableSIMD is true. @thaystg will this cause problems with the debugger? Without this the code follows completely different paths with and without debug enabled and we cannot trim the simd path properly.
extracted from #115062