Enhancing the SqlDbType with vector #115327
Open
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note regarding the |
1 similar comment
|
Note regarding the |
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the SqlDbType enum by adding a new value for vector types to support extended functionality in line with issue #115148.
- Added "Vector" with an assigned value of 36 in the implementation file.
- Updated the reference file to include the new enum member for external consumers.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/libraries/System.Data.Common/src/System/Data/SqlDbType.cs | Added the "Vector" enum value with summary documentation. |
| src/libraries/System.Data.Common/ref/System.Data.Common.cs | Synchronized ref file to include the "Vector" enum member. |
|
Tagging subscribers to this area: @roji, @ajcvickers |
roji
approved these changes
May 6, 2025
This was referenced May 6, 2025
This was referenced May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #115148
The API review is approved.
Similar to #103985, enhancing SqlDbType with vector.