Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

maraf
Copy link
Member

@maraf maraf commented Jul 18, 2025

The check whether the runtime should expect HotReload was move to a HotReload package.
We remove the check from runtime with the removal of built-in Blazor HotReload in dotnet/aspnetcore#62777.

Contributes to dotnet/aspnetcore#61272

@maraf maraf added this to the 10.0.0 milestone Jul 18, 2025
@maraf maraf self-assigned this Jul 18, 2025
@Copilot Copilot AI review requested due to automatic review settings July 18, 2025 08:31
@maraf maraf added the arch-wasm WebAssembly architecture label Jul 18, 2025
@maraf maraf requested a review from lewing as a code owner July 18, 2025 08:31
@maraf maraf requested a review from pavelsavara as a code owner July 18, 2025 08:31
@maraf maraf added the os-browser Browser variant of arch-wasm label Jul 18, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the built-in HotReload detection logic from the Mono browser runtime, as the functionality has been moved to a dedicated HotReload package. The change is part of the removal of built-in Blazor HotReload support in ASP.NET Core.

  • Removes automatic detection of aspnetcore-browser-refresh script
  • Eliminates automatic setting of DOTNET_MODIFIABLE_ASSEMBLIES and __ASPNETCORE_BROWSER_TOOLS environment variables

Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@maraf maraf requested a review from a team July 18, 2025 08:31
@maraf
Copy link
Member Author

maraf commented Jul 18, 2025

/ba-g Timeout is unrelated and covered by other architecture leg

@maraf maraf merged commit 98d12ba into dotnet:main Jul 18, 2025
33 of 39 checks passed
@maraf maraf deleted the BrowserHotReloadCleanup branch July 18, 2025 13:17
@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants