Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[release/10.0] Implement UnhandledException hook for finalizer scenario in Mono.#118878

Merged
jeffschwMSFT merged 12 commits into
release/10.0from
backport/pr-118563-to-release/10.0-rc1
Aug 29, 2025
Merged

[release/10.0] Implement UnhandledException hook for finalizer scenario in Mono.#118878
jeffschwMSFT merged 12 commits into
release/10.0from
backport/pr-118563-to-release/10.0-rc1

Conversation

@github-actions

@github-actions github-actions Bot commented Aug 19, 2025 •
edited by VSadov
Loading

Copy link
Copy Markdown
Contributor

Backport of #118563 to release/10.0

/cc @VSadov

Customer Impact

  • Customer reported
  • Found internally

A Mono counterpart to a new feature already implemented in CoreCLR and NativeAOT. Missed RC snap.

Regression

  • Yes
  • No

[If yes, specify when the regression was introduced. Provide the PR or commit if known.]

Testing

Same tests as used for CoreCLR/NativeAOT are enabled in this change for Mono.

Risk

This is a new feature. Just the Mono part of it missed RC snap.

@dotnet-policy-service dotnet-policy-service Bot added the linkable-framework Issues associated with delivering a linker friendly framework label Aug 19, 2025
This was referenced Aug 19, 2025
Open
Open
Open
@VSadov VSadov requested a review from kotlarmilos August 19, 2025 17:54
@VSadov VSadov added the Servicing-consider Issue for next servicing release review label Aug 19, 2025
@VSadov

VSadov commented Aug 19, 2025

Copy link
Copy Markdown
Member

CC: @mangod9

@VSadov

VSadov commented Aug 19, 2025

Copy link
Copy Markdown
Member

The failure with LLVMFULLAOT is #112557

jeffschwMSFT
jeffschwMSFT approved these changes Aug 20, 2025
View reviewed changes

@jeffschwMSFT jeffschwMSFT left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. we will take for consideration in 10 rc1

@jeffschwMSFT jeffschwMSFT added this to the 10.0.0 milestone Aug 20, 2025
@jeffschwMSFT jeffschwMSFT removed the Servicing-consider Issue for next servicing release review label Aug 21, 2025
@VSadov VSadov changed the base branch from release/10.0-rc1 to release/10.0 August 22, 2025 17:52
@VSadov VSadov changed the title [release/10.0-rc1] Implement UnhandledException hook for finalizer scenario in Mono. [release/10.0] Implement UnhandledException hook for finalizer scenario in Mono. Aug 22, 2025
@VSadov VSadov force-pushed the backport/pr-118563-to-release/10.0-rc1 branch from 639ab88 to 8757fe7 Compare August 22, 2025 17:58
@VSadov VSadov added the Servicing-consider Issue for next servicing release review label Aug 22, 2025
@MichalStrehovsky MichalStrehovsky removed their request for review August 22, 2025 21:29
@VSadov VSadov added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Aug 22, 2025
@VSadov

VSadov commented Aug 22, 2025

Copy link
Copy Markdown
Member

blocking merge to investigate possible issue (#118981)

@VSadov VSadov self-assigned this Aug 23, 2025
@build-analysis build-analysis Bot mentioned this pull request Aug 23, 2025
Closed
@VSadov

VSadov commented Aug 25, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

blocking merge to investigate possible issue (#118981)

That was because couple tests were not supposed to run with llvmaotfull. Added a fix from main to this PR.

@VSadov VSadov removed the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label Aug 25, 2025
@VSadov VSadov force-pushed the backport/pr-118563-to-release/10.0-rc1 branch from 3b637f0 to 6bd4976 Compare August 26, 2025 05:18
@build-analysis build-analysis Bot mentioned this pull request Aug 26, 2025
Open
@lewing lewing added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Aug 26, 2025
@lewing

lewing commented Aug 26, 2025

Copy link
Copy Markdown
Member

marking approved since @jeffschwMSFT approved

@VSadov VSadov force-pushed the backport/pr-118563-to-release/10.0-rc1 branch from 6bd4976 to 1856d3d Compare August 28, 2025 05:22
@VSadov

VSadov commented Aug 28, 2025

Copy link
Copy Markdown
Member

The failure does not seem to be related to finalizers.

11:39:41.246 Passed test: _Runtime_101731::Runtime_101731.TestConvertToInt32NativeDouble(1.7976931348623157E+308)
11:39:41.247 Running test: _Runtime_101731::Runtime_101731.TestConvertToInt32NativeSingle(3.4028235E+38)
11:39:41.247 Passed test: _Runtime_101731::Runtime_101731.TestConvertToInt32NativeSingle(3.4028235E+38)
11:39:41.248 Running test: _Runtime_101731::Runtime_101731.TestConvertToInt64NativeDouble(1.7976931348623157E+308)
11:39:41.249 Passed test: _Runtime_101731::Runtime_101731.TestConvertToInt64NativeDouble(1.7976931348623157E+308)
11:39:41.249 Running test: _Runtime_101731::Runtime_101731.TestConvertToInt64NativeSingle(3.4028235E+38)
App Exit Code: 22
Expected: 100
Actual: 22
END EXECUTION - FAILED
+ test_exit_code=1

@VSadov VSadov force-pushed the backport/pr-118563-to-release/10.0-rc1 branch from 1856d3d to 1ed52da Compare August 28, 2025 16:26
@VSadov

VSadov commented Aug 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

The errors are the same as without this change (ex: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1134198&view=ms.vss-test-web.build-test-results-tab)

I think we can merge this.

@VSadov

VSadov commented Aug 29, 2025

Copy link
Copy Markdown
Member

I do not have permissions to merge though . . .

@mangod9

mangod9 commented Aug 29, 2025

Copy link
Copy Markdown
Member

@jeffschwMSFT should be able to merge.

@jeffschwMSFT jeffschwMSFT merged commit 39349e8 into release/10.0 Aug 29, 2025
130 of 133 checks passed
@VSadov

VSadov commented Aug 29, 2025

Copy link
Copy Markdown
Member

Thanks!

@VSadov VSadov deleted the backport/pr-118563-to-release/10.0-rc1 branch August 29, 2025 16:09
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@BrzVlad BrzVlad BrzVlad approved these changes
@jeffschwMSFT jeffschwMSFT jeffschwMSFT approved these changes
@kotlarmilos kotlarmilos kotlarmilos approved these changes
@mangod9 mangod9 mangod9 approved these changes
@steveisok steveisok Awaiting requested review from steveisok steveisok is a code owner
@vitek-karas vitek-karas Awaiting requested review from vitek-karas vitek-karas is a code owner
@thaystg thaystg Awaiting requested review from thaystg thaystg is a code owner
@marek-safar marek-safar Awaiting requested review from marek-safar
@sbomer sbomer Awaiting requested review from sbomer

Assignees

@VSadov VSadov

Labels

area-VM-meta-mono linkable-framework Issues associated with delivering a linker friendly framework Servicing-approved Approved for servicing release

Projects

None yet

Milestone

10.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@VSadov @lewing @mangod9 @BrzVlad @jeffschwMSFT @kotlarmilos