[release/10.0] Throttle finalization a bit when doing GC stress.#119044
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @mangod9 |
fd9d7b7 to
89b20dc
Compare
Member
|
/azp run runtime-coreclr gcstress-extra, runtime-coreclr gcstress0x3-gcstress0xc |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Member
|
The error: Can we run GC stress in |
jeffschwMSFT
approved these changes
Aug 25, 2025
jeffschwMSFT
left a comment
Member
There was a problem hiding this comment.
approved. please get a code review. we can merge when ready
mangod9
approved these changes
Aug 25, 2025
89b20dc to
af4a130
Compare
Member
|
/azp run runtime-coreclr gcstress-extra, runtime-coreclr gcstress0x3-gcstress0xc |
|
Azure Pipelines successfully started running 2 pipeline(s). |
af4a130 to
352edb7
Compare
352edb7 to
22797dc
Compare
Member
|
/azp run runtime-coreclr gcstress-extra |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
@jeffschwMSFT I think we can merge this. Some tests are failing because some pipelines appear to not have permissions to run in The change achieves its purpose though - the GC stress on osx-arm64 passes and takes under one hour. Errors: |
Member
|
Thanks!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #114581
Backport of #118879 to release/10.0
/cc @VSadov
Customer Impact
This is an internal test-only change.
This likely regressed slowly over time. On one hand we had improvements in finalization and suspension, on the other we've introduced patterns that rely on finalizable objects re-arming themselves as a way to perform some actions in response to gen2 GCs. (as in
GC.ReRegisterForFinalize(this))One unintended result is that a few such re-arming objects can consume a lot of resources when running under GC stress as these patterns end up causing a lot of GCs, which do not help with the coverage as they just keep re-arming each other and cause more GCs.
Some platforms like
osx-arm64/win-arm64now take hours to complete GC stress and often fail with a timeout.This is unacceptable for a branch that may take servicing changes that require running GC stress.
Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
GC stress testing was triggered on this PR.
Risk
Low.
All the changes are under
#ifdef DEBUGas GC stress infra is not included in Release builds.