[browser] Remove AttachWeakETagToCompressedAssetsDuringDevelopment workaround from Wasm.Build.Tests #119494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom WASM test files Co-authored-by: maraf <[email protected]>
AttachWeakETagToCompressedAssetsDuringDevelopment made in https://github.com/dotnet/runtime/pull/118914
Copilot finished work on behalf of
maraf
September 9, 2025 15:55
This was referenced Sep 9, 2025
|
Tagging subscribers to this area: @akoeplinger, @matouskozak, @simonrozsival |
There was a problem hiding this comment.
Pull Request Overview
This PR removes a temporary workaround property AttachWeakETagToCompressedAssetsDuringDevelopment from WASM build test infrastructure files. The workaround was originally added to address build issues but is no longer needed and was scheduled for removal per issue #118967.
- Removed the
AttachWeakETagToCompressedAssetsDuringDevelopment=trueproperty and associated comments from WASM test configuration files - Simplified test data Directory.Build.props files back to their original minimal
<Project />format - Verified WASM libraries continue to build successfully without the workaround
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/mono/wasm/testassets/Directory.Build.props | Removed workaround PropertyGroup while preserving Import statement |
| src/mono/wasm/Wasm.Build.Tests/data/Workloads.Directory.Build.props | Simplified from full PropertyGroup to minimal <Project /> format |
| src/mono/wasm/Wasm.Build.Tests/Directory.Build.props | Removed workaround property and comment from existing PropertyGroup |
|
Tagging subscribers to 'arch-wasm': @lewing |
maraf
approved these changes
Sep 10, 2025
javiercn
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #118967 by removing the
AttachWeakETagToCompressedAssetsDuringDevelopmentworkaround that was added in PR #118914.This workaround was temporarily added to WASM test infrastructure files to address build issues, but is no longer needed and should be removed as tracked in issue #118967.
Changes
AttachWeakETagToCompressedAssetsDuringDevelopment=trueproperty from all WASM test Directory.Build.props files<Project />formatFiles Modified
src/mono/wasm/Wasm.Build.Tests/Directory.Build.props- Removed workaround propertysrc/mono/wasm/Wasm.Build.Tests/data/Local.Directory.Build.props- Reverted to simple formatsrc/mono/wasm/Wasm.Build.Tests/data/Blazor.Directory.Build.props- Reverted to simple formatsrc/mono/wasm/Wasm.Build.Tests/data/Workloads.Directory.Build.props- Reverted to simple formatsrc/mono/wasm/testassets/Directory.Build.props- Removed workaround PropertyGroupTesting
Verified that WASM libraries build successfully without the workaround:
./build.sh mono -os browser- ✅ Success./build.sh libs -os browser- ✅ SuccessConfirmed no remaining references to
AttachWeakETagToCompressedAssetsDuringDevelopmentexist in the codebase.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.