HMAC Verify #119652
Open
HMAC Verify #119652
+2,573
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
There was a problem hiding this comment.
Pull Request Overview
This PR adds HMAC "Verify" APIs for validating HMAC signatures across the cryptographic library. The changes introduce new verification methods that perform fixed-time comparisons to prevent timing attacks.
Key changes include:
- Addition of new
VerifyandVerifyAsyncmethods to all HMAC classes (HMACSHA1, HMACSHA256, HMACSHA384, HMACSHA512, HMACSHA3_256, HMACSHA3_384, HMACSHA3_512, HMACMD5) - New verification APIs in
CryptographicOperationsclass for general HMAC verification - Addition of
VerifyCurrentHashandVerifyHashAndResetmethods toIncrementalHashclass - Creation of shared implementation infrastructure through
HMACSharedclass
Reviewed Changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
IncrementalHashTests.cs |
Adds comprehensive test coverage for new verify methods in IncrementalHash |
HmacTests.cs |
Adds base test infrastructure and validation tests for HMAC verification APIs |
HmacSha*.cs (test files) |
Implements abstract verify methods for each HMAC algorithm test class |
IncrementalHash.cs |
Implements VerifyCurrentHash and VerifyHashAndReset methods |
HMACShared.cs |
New shared implementation for HMAC verification logic across all algorithms |
HMAC*.cs (implementation files) |
Adds Verify and VerifyAsync static methods to each HMAC class |
CryptographicOperations.cs |
Adds general-purpose HMAC verification APIs |
| Project and reference files | Updates to include new HMACShared.cs file and API surface |
src/libraries/System.Security.Cryptography/tests/IncrementalHashTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography/tests/IncrementalHashTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography/tests/IncrementalHashTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Security.Cryptography/tests/IncrementalHashTests.cs
Outdated
Show resolved
Hide resolved
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds HMAC "Verify" APIs for validating an HMAC signature.
KMAC will be a followup PR.
Contributes to #116028