[wasm][coreclr] Implement RhpNewArrayFastAlign8#120690
Merged
radekdoulik merged 8 commits intoOct 16, 2025
Merged
Conversation
Contributor
|
Tagging subscribers to this area: @mangod9 |
jkotas
reviewed
Oct 14, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements the RhpNewArrayFastAlign8 function for WASM and CoreCLR, resolving issue #120659. The implementation enables aligned memory allocation for arrays that require 8-byte alignment, particularly for long and double arrays on 32-bit platforms.
Key changes:
- Implements the
RhpNewArrayFastAlign8function with proper alignment logic - Refactors existing allocation code to improve maintainability
- Removes WASM-specific test exclusions that are no longer needed
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/coreclr/runtime/portable/AllocFast.cpp | Implements RhpNewArrayFastAlign8 function and refactors allocation helpers |
| src/tests/JIT/interpreter/Interpreter.cs | Removes WASM architecture exclusions for long and double array tests |
Co-authored-by: Aaron Robinson <[email protected]>
AaronRobinsonMSFT
left a comment
Member
There was a problem hiding this comment.
Overall, LGTM. I'm like to try and remove some of the "magic" numbers in NewArrayFastAlign8Core. There must be some simple macros or computation to get them.
jkotas
reviewed
Oct 15, 2025
jkotas
reviewed
Oct 15, 2025
jkotas
reviewed
Oct 15, 2025
jkotas
reviewed
Oct 15, 2025
jkotas
reviewed
Oct 15, 2025
jkotas
reviewed
Oct 15, 2025
Co-authored-by: Jan Kotas <[email protected]>
jkotas
approved these changes
Oct 15, 2025
jkotas
reviewed
Oct 15, 2025
jkotas
approved these changes
Oct 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #120659