[RuntimeAsync] Use truncating sprintf to make resumption stub names#120698
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a CRT assert dialog issue in debug/checked builds when creating async resumption stub names. The change replaces sprintf_s with _snprintf_s using the _TRUNCATE option to handle cases where method names are too long for the fixed-size buffer.
Key changes:
- Switches from
sprintf_sto_snprintf_swith_TRUNCATEflag to prevent CRT assertion dialogs - Maintains the same buffer size and error checking logic
Contributor
|
Tagging subscribers to this area: @mangod9 |
jakobbotsch
reviewed
Oct 14, 2025
jakobbotsch
approved these changes
Oct 15, 2025
Member
Author
|
/ba-g the failures are all #120577 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sprintf_spops a crt assert dialog in checked/debug if the buffer is too short._snprintf_swith_TRUNCATEdoes not have such problem.We may see some pretty long names here.
An example that was triggering the assert in #119432 was:
System.Collections.Generic.IAsyncEnumerator<System.ValueTuple<Microsoft.CodeAnalysis.Project,System.Collections.Immutable.ImmutableArray<System.ValueTuple<Microsoft.CodeAnalysis.ISymbol,Microsoft.CodeAnalysis.FindSymbols.SymbolGroup>>>>.MoveNextAsync