[clr-interp] Fix cconv issue in InterpreterStub on linux-x64#120738
Merged
Conversation
It seems like this code was copied over from windows version, with minor oversight leading to passing first arg in rcx instead of rdi.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a calling convention issue in the InterpreterStub assembly code for linux-x64. The code was incorrectly using the Windows calling convention (passing the first argument in rcx) instead of the System V ABI calling convention used on Linux (passing the first argument in rdi).
Key Changes
- Updates the register used for the first function argument from
rcxtordiin the InterpreterStub assembly code - Aligns the code with the correct calling convention for linux-x64 platform
Contributor
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
kg
approved these changes
Oct 15, 2025
Member
|
/ba-g recently fixed known issue #120577 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like this code was copied over from windows version, with minor oversight leading to passing first arg in rcx instead of rdi.