[clr-interp] Array allocation exception has incorrect exception#120981
Merged
davidwrighton merged 1 commit intoOct 22, 2025
Conversation
davidwrighton
commented
Oct 22, 2025
Member
- The actual helper throws the right exception (which is OverflowException)
- Don't add an incorrect check
- The actual helper throws the right exception (which is OverflowException) - Don't add an incorrect check
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an exception handling issue in the CLR interpreter's array allocation code. The removed manual validation was throwing the wrong exception type (ArgumentOutOfRangeException) when it should throw OverflowException, which the underlying helper already correctly handles.
- Removes duplicate and incorrect exception checks for negative array lengths in INTOP_NEWARR and INTOP_NEWARR_GENERIC cases
- Relies on the helper function to throw the correct OverflowException instead
kg
approved these changes
Oct 22, 2025
jkotas
reviewed
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.