Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix WriteLargeJsonToStreamWithoutFlushing test #34489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2020
Merged

Fix WriteLargeJsonToStreamWithoutFlushing test #34489

merged 1 commit into from
Apr 3, 2020

Conversation

layomia
Copy link
Contributor

@layomia layomia commented Apr 3, 2020 •
edited
Loading

Fixes #34481.

This test wasn't updated following #32587, where the exception for this scenario changed from OverflowException to OutOfMemoryException.

@layomia layomia self-assigned this Apr 3, 2020
@layomia layomia added this to the 5.0 milestone Apr 3, 2020
@layomia layomia mentioned this pull request Apr 3, 2020
Closed
@layomia
Copy link
Contributor Author

layomia commented Apr 3, 2020

cc @danmosemsft

@stephentoub
Copy link
Member

Thanks.

@stephentoub stephentoub merged commit 07187e3 into dotnet:master Apr 3, 2020
@danmoseley
Copy link
Member

How did it get through gated checkin, do you know @layomia?

@stephentoub
Copy link
Member

It's OuterLoop.

@danmoseley
Copy link
Member

Thanks. As soon as I commented I realized that.

@layomia layomia mentioned this pull request Apr 13, 2020
Closed
layomia added a commit to layomia/dotnet_runtime that referenced this pull request Apr 13, 2020
@layomia
Fix WriteLargeJsonToStreamWithoutFlushing test (dotnet#34489)
072339b
@layomia layomia mentioned this pull request Apr 13, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
@layomia layomia deleted the writer_test branch May 18, 2021 07:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

@ahsonkhan ahsonkhan Awaiting requested review from ahsonkhan

@jozkee jozkee Awaiting requested review from jozkee

@steveharter steveharter Awaiting requested review from steveharter

Assignees

@layomia layomia

Labels
area-System.Text.Json
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

WriteLargeJsonToStreamWithoutFlushing failing in libraries outer loop
4 participants
@layomia @stephentoub @danmoseley @Dotnet-GitSync-Bot