Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Single-File Bundler: Add a FileSize test #35149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2020

Conversation

swaroop-sridhar
Copy link
Contributor

Add a bundler consistency tests that verifies that the size of each embedded file (recorded in the bundle manifest) matches its original size of the file on disk.

Add a bundler consistency tests that verifies that the size of each embedded file
(recorded in the bundle manifest) matches its original size of the file on disk.
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the area-HostModel Microsoft.NET.HostModel issues label Apr 18, 2020
@ghost
Copy link

ghost commented Apr 18, 2020

Tagging subscribers to this area: @vitek-karas, @swaroop-sridhar
Notify danmosemsft if you want to be subscribed.

@swaroop-sridhar swaroop-sridhar merged commit 779588a into dotnet:master Apr 20, 2020
swaroop-sridhar added a commit to swaroop-sridhar/runtime that referenced this pull request Apr 30, 2020
This commit reverts:
Revert "Single-File: Process bundles in the framework (dotnet#34274)"
This reverts commit 78b303d.

Revert "Single-File Bundler: Add a FileSize test (dotnet#35149)"
This reverts commit 779588a.
swaroop-sridhar added a commit that referenced this pull request May 1, 2020
This commit reverts:
Revert "Single-File: Process bundles in the framework (#34274)"
This reverts commit 78b303d.

Revert "Single-File Bundler: Add a FileSize test (#35149)"
This reverts commit 779588a.

*Customer Scenario*

Publishing apps as a self-contained single-file doesn't work as expected.

* Publish needs to generate hostpolicy and hostfxr separate from the single file bundle
* Cross-platform publishing is incorrect

*Problem*

Since Static-apphost is not yet ready, processing bundle content in hostpolicy means that  hostpolicy and hostfxr DLLs need to be separate from the bundle. This causes self-contained single-file apps to not be a "single file" temporarily. 

The change also requires supporting changes from the SDK, to publish hostfxr and hostpolicy as separate files, and to invoke HostModel library with arguments that facilitate cross-platform publishing.

*Solution*

To solve these, problem, this change reverts:

Revert "Single-File: Process bundles in the framework (#34274)" commit 78b303d.

and a dependent test-only change:

Revert "Single-File Bundler: Add a FileSize test (#35149)" commit 779588a.

*Risk*

Medium
The change is contained to only host components: apphost, hostpolicy, and hostfxr.
However, the change is big, and needs testing in runtime and SDK repos.

*Testing*

Manually tested the SDK by inserting apphost, hostfxr, hostpolicy, and hostmodel library from this build into the `dotnet/packs` preview-4 SDK from dotnet/sdk#11518 build.

Verified that:
* Singlefile apps can be published and run OK for  { Windows, Linux, Osx } x {netcoreapp3.0, netcoreapp3.1, netcoreapp5.0} 
* Cross-targeting builds of single-file apps build and run OK (ex: built on Windos, run on Mac).
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-HostModel Microsoft.NET.HostModel issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants