Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Move AdvSimd check from PAL to VM #38425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 26, 2020
Merged

Move AdvSimd check from PAL to VM #38425

merged 3 commits into from
Jun 26, 2020

Conversation

kunalspathak
Copy link
Contributor

As per discussion in #38060 (comment) , making following changes:

  • Remove redundant for Set64BitInstructionSetVariants() and CPUCompileFlags.EnsureValidInstructionSetSupport() from PAL
  • Reverted part of the changes I did in Crossgen method bodies having ARM64 intrinsic #38060 and move the check of AdvSimd presence in case of TARGET_UNIX from PAL to codeman.cpp .

tannergooding
tannergooding reviewed Jun 26, 2020
View reviewed changes
@kunalspathak
Copy link
Contributor Author

@janvorli , @davidwrighton , @BruceForstall

@kunalspathak kunalspathak marked this pull request as ready for review June 26, 2020 18:08
janvorli
janvorli approved these changes Jun 26, 2020
View reviewed changes
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@kunalspathak kunalspathak merged commit fbe4d10 into dotnet:master Jun 26, 2020
@AntonLapounov AntonLapounov mentioned this pull request Aug 10, 2020
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tannergooding tannergooding tannergooding left review comments

@janvorli janvorli janvorli approved these changes

@davidwrighton davidwrighton davidwrighton approved these changes

Assignees
No one assigned
Labels
area-PAL-coreclr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kunalspathak @tannergooding @janvorli @davidwrighton @Dotnet-GitSync-Bot