Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Allow enregistering more structs args #39326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 7, 2020
Merged

Allow enregistering more structs args #39326

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2c51383
Allow enregistering more structs args
CarolEidt Jun 18, 2020
69c19f2
PR feedback and fix mixed type on x64/ux
CarolEidt Jul 15, 2020
b446edc
Fix for ARM HFA
CarolEidt Sep 22, 2020
7595c68
Clear multi-reg flag on lclVar if source is not multi-reg.
CarolEidt Sep 24, 2020
134dd48
Clarify comment
CarolEidt Sep 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Clarify comment
  • Loading branch information
@CarolEidt
CarolEidt committed Oct 6, 2020
commit 134dd48d6a9a8186cdadcb89b2d4a82edaa5bf82
4 changes: 3 additions & 1 deletion src/coreclr/src/jit/morph.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17591,7 +17591,9 @@ void Compiler::fgPromoteStructs()
lvaStructPromotionInfo structPromotionInfo;
bool tooManyLocalsReported = false;

// Clear the structPromotionHelper, since it is conservative about looking up SIMD info.
// Clear the structPromotionHelper, since it is used during inlining, at which point it
// may be conservative about looking up SIMD info.
// We don't want to preserve those conservative decisions for the actual struct promotion.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation and the comment, I would probably rephrase it as: since it is used during importation for inlining decisions.

the place that uses it before we call struct promotion is:

runtime/src/coreclr/src/jit/importer.cpp

Lines 18651 to 18658 in 334bd84

// Note if the callee's class is a promotable struct
if ((info.compClassAttr & CORINFO_FLG_VALUECLASS) != 0)
{
assert(structPromotionHelper != nullptr);
if (structPromotionHelper->CanPromoteStructType(info.compClassHnd))
{
inlineResult->Note(InlineObservation::CALLEE_CLASS_PROMOTABLE);
}

structPromotionHelper->Clear();

for (unsigned lclNum = 0; lclNum < startLvaCount; lclNum++)
Expand Down