[wasm] Address TODO in pal_runtimeinformation.c #40133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WASM architecture wasn't added there since we already hardcode the architecture to wasm in the managed layer. For consistency we should still define it in the PAL though and address the TODO comment. Also added a test that verifies we indeed get the correct wasm architecture on the Browser platform.
steveisok
approved these changes
Jul 30, 2020
|
Failure is due to #40112 |
Jacksondr5
pushed a commit
to Jacksondr5/runtime
that referenced
this pull request
Aug 10, 2020
The WASM architecture wasn't added there since we already hardcode the architecture to wasm in the managed layer. For consistency we should still define it in the PAL though and address the TODO comment. Also added a test that verifies we indeed get the correct wasm architecture on the Browser platform.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The WASM architecture wasn't added there since we already hardcode the architecture to wasm in the managed layer.
For consistency we should still define it in the PAL though and address the TODO comment.
Also added a test that verifies we indeed get the correct wasm architecture on the Browser platform.