Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Apple Silicon reenable 49110 failures #52195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 9, 2021
Merged

Apple Silicon reenable 49110 failures #52195

merged 2 commits into from
Jun 9, 2021

Conversation

sdmaclea
Copy link
Contributor

@sdmaclea sdmaclea commented May 3, 2021

These issues were likely fixed in CI by dotnet/core-eng#12776

Fixes #49110

@sdmaclea sdmaclea added this to the 6.0.0 milestone May 3, 2021
@sdmaclea sdmaclea self-assigned this May 3, 2021
@ghost
Copy link

ghost commented May 3, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

These issues were likely fixed in CI by dotnet/core-eng#12776

Fixes #49110

Author: sdmaclea
Assignees: sdmaclea
Labels:

arch-arm64, area-Infrastructure-libraries, os-mac-os-x-big-sur
Milestone: 6.0.0

@sdmaclea sdmaclea requested a review from safern May 3, 2021 17:11
safern
safern reviewed May 3, 2021
View reviewed changes
src/libraries/tests.proj
@@ -299,56 +299,6 @@
<!-- ActiveIssue Apple Silicon No usable version of libssl was found https://github.com/dotnet/runtime/issues/49083 -->
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Security.Cryptography.Algorithms/tests/System.Security.Cryptography.Algorithms.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Security.Cryptography.OpenSsl/tests/System.Security.Cryptography.OpenSsl.Tests.csproj" />
<!-- ActiveIssue XUnit crashes on Apple Silicon https://github.com/dotnet/runtime/issues/49110 -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could all these that were crashing uncover other test failures? Let's make sure before merging that the build is still green.

@sdmaclea
Copy link
Contributor Author

sdmaclea commented May 3, 2021

/azp run runtime-libraries-coreclr outerloop-osx

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sdmaclea
Copy link
Contributor Author

sdmaclea commented May 3, 2021 •
edited
Loading

Manually triggered https://dev.azure.com/dnceng/public/_build/results?buildId=1119668&view=results

@sdmaclea
Copy link
Contributor Author

/azp run runtime-libraries-coreclr outerloop-osx

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sdmaclea
Copy link
Contributor Author

Manually triggered https://dev.azure.com/dnceng/public/_build/results?buildId=1130954&view=results

@sdmaclea
Copy link
Contributor Author

Runtime staging https://dev.azure.com/dnceng/public/_build/results?buildId=1119668&view=results had three libraries innerloop failures.

@sdmaclea sdmaclea added the NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) label May 10, 2021
@karelz karelz mentioned this pull request May 10, 2021
Closed
@ericstj
Copy link
Member

ericstj commented Jun 7, 2021

@sdmaclea does this need a rerun or do you think these weren't fixed by dotnet/core-eng#12776?

@sdmaclea
Copy link
Contributor Author

sdmaclea commented Jun 8, 2021

These weren't fixed by dotnet/core-eng#12776.

Unfortunately most of these issues do not reproduce (easily?) locally anymore.

The original runs didn't generate core dumps. The coredumps have since been fixed. I planned to rebase and rerun these to see if we could get some more info.

/cc @janvorli @mangod9 @sandreenko

@sdmaclea
Copy link
Contributor Author

sdmaclea commented Jun 8, 2021

Rebased and manually triggered https://dev.azure.com/dnceng/public/_build/results?buildId=1176673&view=results

@sdmaclea sdmaclea marked this pull request as draft June 8, 2021 16:37
@sdmaclea
Copy link
Contributor Author

sdmaclea commented Jun 8, 2021

/azp run runtime-libraries-coreclr outerloop-osx

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sdmaclea
Copy link
Contributor Author

sdmaclea commented Jun 8, 2021 •
edited
Loading

There are some coredumps for a bus error and a segmentation fault https://dev.azure.com/dnceng/public/_build/results?buildId=1176673

There is also this interesting delegate test failure

  Starting:    System.Runtime.Tests (parallel test collections = on, max threads = 8)
    System.Tests.DelegateTests.DynamicInvoke_DefaultParameter_AllPrimitiveParametersWithSomeExplicitValues [FAIL]
      Assert.Equal() Failure
                                       ↓ (pos 38)
      Expected: ··· -101, -3, 104, -5, 106, -7, 108, 9.1, 111.12
      Actual:   ··· -101, -3, 104, -5, 4294967291, -7, 108, 9.1, 111.12
                                       ↑ (pos 38)
      Stack Trace:
        /_/src/libraries/System.Runtime/tests/System/DelegateTests.cs(253,0): at System.Tests.DelegateTests.DynamicInvoke_DefaultParameter_AllPrimitiveParametersWithSomeExplicitValues()
    System.Tests.DelegateTests.DynamicInvoke_DefaultParameter_AllPrimitiveParametersWithMissingValues [FAIL]
      Assert.Equal() Failure
                                       ↓ (pos 33)
      Expected: ···, 2, -1, -3, 4, -5, 6, -7, 8, 9.1, 11.12
      Actual:   ···, 2, -1, -3, 4, -5, 4294967291, -7, 8, 9.1, 11.12
                                       ↑ (pos 33)
    System.Tests.DelegateTests.DynamicInvoke_DefaultParameter_AllPrimitiveParametersWithAllExplicitValues [FAIL]
      Assert.Equal() Failure
                                       ↓ (pos 45)
      Expected: ···1, -103, 104, -105, 106, -107, 108, 109.1, 111.12
      Actual:   ···1, -103, 104, -105, 4294967191, -107, 108, 109.1, 111.12
                                       ↑ (pos 45)
      Stack Trace:
        /_/src/libraries/System.Runtime/tests/System/DelegateTests.cs(228,0): at System.Tests.DelegateTests.DynamicInvoke_DefaultParameter_AllPrimitiveParametersWithAllExplicitValues()

Looks like an ABI issue which was covered by the disabled tests. Perhaps it was fixed by #53250 which was merged after this was triggered. Or perhaps it is an instance of the XUnit test data getting corrupted since the same bad data occurs in three separate tests.

@sdmaclea
Copy link
Contributor Author

sdmaclea commented Jun 8, 2021

This run the same test suites failed. https://dev.azure.com/dnceng/public/_build/results?buildId=1177129

But the interesting case is gone. Perhaps it is fixed or intermittent.

@sdmaclea
Restore test disables
ebf54ea 
System.Numerics.Vectors & System.Runtime both failed
for both runs.  Restore disables of these tests.
@sdmaclea
Copy link
Contributor Author

sdmaclea commented Jun 9, 2021

/azp run runtime-libraries-coreclr outerloop-osx

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sdmaclea sdmaclea marked this pull request as ready for review June 9, 2021 23:27
@sdmaclea sdmaclea merged commit 626ceb7 into dotnet:main Jun 9, 2021
@sdmaclea sdmaclea mentioned this pull request Jun 9, 2021
Closed
@sdmaclea sdmaclea deleted the reenable49110 branch June 10, 2021 00:30
@ghost ghost locked as resolved and limited conversation to collaborators Jul 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@safern safern safern approved these changes

Assignees

@sdmaclea sdmaclea

Labels
arch-arm64 area-Infrastructure-libraries NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) os-macos-bigsur (macOS11)
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

[macOS-arm64] XUnit crashes while running libraries tests on CoreCLR
3 participants
@sdmaclea @ericstj @safern