Expose RoundUpToPowerOf2 #53992
Expose RoundUpToPowerOf2 #53992
Conversation
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @tannergooding, @pgovind Issue DetailsCloses #43135 A special fast path for operating 32bit number on 64bit platform, which should be most common.
|
| [InlineData(2u, 2u)] | ||
| [InlineData(0x7FFF_FFFFu, 0x8000_0000u)] | ||
| [InlineData(0x8000_0000u, 0x8000_0000u)] | ||
| [InlineData(0xFFFF_FFFFu, 0)] |
There was a problem hiding this comment.
Can we also add a test for 8000_0001? and a couple values between 2 and int.MaxValue?
Just a couple random values rather than explicitly just the edge cases would be useful I think
There was a problem hiding this comment.
I got them literally using Random
|
Can you replace and with use of the new API? |
|
Done |
src/libraries/System.Private.CoreLib/src/System/Numerics/BitOperations.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Private.CoreLib/src/System/Numerics/BitOperations.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Stephen Toub <[email protected]>
|
/azp run runtime-coreclr jitstress-isas-x86, runtime-coreclr jitstress-isas-arm |
|
I've kicked off the outerloop ISA jobs to ensure the software fallback is tested. It should be good to merge once those complete. |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
Hello @tannergooding! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Closes #43135
A special fast path for operating 32bit number on 64bit platform, which should be most common.