Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Support generating log methods in nested classes #54180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 15, 2021
Merged

Support generating log methods in nested classes #54180

merged 6 commits into from
Jun 15, 2021

Conversation

maryamariyan
Copy link
Contributor

@maryamariyan maryamariyan commented Jun 14, 2021 •
edited
Loading

  • Add test for non static nested case
  • Support log methods in nested records/structs/classes

Fixes #52301

@ghost
Copy link

ghost commented Jun 14, 2021

Tagging subscribers to this area: @maryamariyan
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Add tests
Author: maryamariyan
Assignees: -
Labels:

area-Extensions-Logging
Milestone: -

@maryamariyan maryamariyan self-assigned this Jun 14, 2021
@maryamariyan
Copy link
Contributor Author

Notes for review:

  • Might be easier to review by commit (second commit is just a resx change)
  • Review tests first, then Parser, then Emitter code changes

@maryamariyan maryamariyan mentioned this pull request Jun 14, 2021
Closed
24 tasks
@maryamariyan
Apply some PR feedback
cf9affd
@maryamariyan
- Remove variable indentationSize
1314e81 
- Add test for non static nested case
- Add support for log method directly in structs
- Support log methods in nested records/structs
@maryamariyan
- Cleanup tests
2b22cd7 
- Undo support for loggers directrly under struct
@maryamariyan maryamariyan marked this pull request as ready for review June 15, 2021 21:35
eerhardt
eerhardt approved these changes Jun 15, 2021
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the good work here!

@maryamariyan maryamariyan force-pushed the support-nested-logs branch 2 times, most recently from 6f872e5 to 5e9f356 Compare June 15, 2021 22:07
@maryamariyan maryamariyan reopened this Jun 15, 2021
@maryamariyan maryamariyan force-pushed the support-nested-logs branch from 5e9f356 to 61e76f5 Compare June 15, 2021 22:17
@maryamariyan maryamariyan merged commit d0ca735 into dotnet:main Jun 15, 2021
@maryamariyan maryamariyan deleted the support-nested-logs branch June 15, 2021 22:36
@maryamariyan
Copy link
Contributor Author

/backport to release/5.0-preview6

@github-actions
Copy link
Contributor

Started backporting to release/5.0-preview6: https://github.com/dotnet/runtime/actions/runs/940940800

@github-actions
Copy link
Contributor

@maryamariyan an error occurred while backporting to release/5.0-preview6, please check the run log for details!

Error: The specified backport target branch release/5.0-preview6 wasn't found in the repo.

@maryamariyan
Copy link
Contributor Author

/backport to release/6.0-preview6

@github-actions
Copy link
Contributor

Started backporting to release/6.0-preview6: https://github.com/dotnet/runtime/actions/runs/940950152

@github-actions github-actions bot mentioned this pull request Jun 15, 2021
Merged
@maryamariyan maryamariyan mentioned this pull request Jun 15, 2021
Closed
@maryamariyan
Copy link
Contributor Author

CI results from later commits in the PR: buildId 1188639

More CI related to the PR here:

@ghost ghost locked as resolved and limited conversation to collaborators Jul 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eerhardt eerhardt eerhardt approved these changes

@tarekgh tarekgh Awaiting requested review from tarekgh

@davidfowl davidfowl Awaiting requested review from davidfowl

Assignees

@maryamariyan maryamariyan

Labels
area-Extensions-Logging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support nested logging classes in Logging Source Generator
2 participants
@maryamariyan @eerhardt