Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[resubmit] BigInteger parsing optimization for large decimal string #55121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Mar 23, 2022
Merged

[resubmit] BigInteger parsing optimization for large decimal string #55121

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
e93dde5
implement divide-and-conquer method for parsing digits
key-moon Apr 27, 2021
2fdbe45
fix argument order in Assert when x equals to 0
key-moon Apr 27, 2021
7d89c46
Apply format fix
key-moon May 26, 2021
417a8a3
add test for non-naive algorithm
key-moon Sep 23, 2021
eb7be98
add description for naiveThreshold
key-moon Sep 23, 2021
8f79da7
fix trivial part
key-moon Sep 23, 2021
9a432db
add check for boundary condition
key-moon Sep 24, 2021
fce80e8
add assertions and descriptions
key-moon Sep 24, 2021
f6eadca
change variable name
key-moon Sep 24, 2021
c3903db
remove inappropreate use of var
key-moon Oct 7, 2021
a9942c5
to use ArrayPool<int>.Shared.Rent for newBuffer allocation
key-moon Oct 8, 2021
460664f
move both algorithms to separate methods
key-moon Oct 9, 2021
607f51c
add and fix comments
key-moon Oct 9, 2021
7f9fcd8
merge main branch to resolve conflicts
key-moon Oct 10, 2021
470d761
trivial fix
key-moon Jan 27, 2022
b1c717b
Merge branch 'main' into bigint-parse-divide-conquer
key-moon Feb 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add description for naiveThreshold
  • Loading branch information
@key-moon
key-moon committed Sep 23, 2021
commit eb7be98b9bc1d12297a45ee8da417e384474ea6f
7 changes: 7 additions & 0 deletions src/libraries/System.Runtime.Numerics/src/System/Numerics/BigNumber.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,6 +494,13 @@ private static bool HexNumberToBigInteger(ref BigNumberBuffer number, out BigInt
}
}

//
// This threshold is for choosing the algorithm to use based on the number of digits.
//
// Let N be the number of digits. If N is less than or equal to the bound, use a naive
// algorithm with a running time of O(N^2). And if it is greater than the threshold, use
// a divide-and-conquer algorithm with a running time of O(NlogN).
//
private static int s_naiveThreshold = 20000;
private static bool NumberToBigInteger(ref BigNumberBuffer number, out BigInteger result)
{
Expand Down