Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Expose nint/nuint overloads for BitOperations #58733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Sep 17, 2021
Merged

Expose nint/nuint overloads for BitOperations #58733

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
2bbb78c
Change access modifier of BitOperations.IsPow2
deeprobin Sep 6, 2021
eafa631
Add CLSCompliant(false) attribute to BitOperations.IsPow2
deeprobin Sep 6, 2021
4790b58
Add BitOperations.RoundUpToPowerOf2 method for nuint
deeprobin Sep 6, 2021
fecdac6
Add BitOperations.LeadingZeroCount method for nuint
deeprobin Sep 6, 2021
ca63abc
Add BitOperations.Log2 method for nuint
deeprobin Sep 6, 2021
f6e497b
Add BitOperations.PopCount method for nuint
deeprobin Sep 6, 2021
4aaab92
Add BitOperations.TrailingZeroCount for nint and nuint
deeprobin Sep 6, 2021
a46a61b
Add BitOperations.RotateLeft and BitOperations.RotateRight for nuint
deeprobin Sep 6, 2021
7ff6414
Replace Environment.Is64BitProcess check with preprocessor variable T…
deeprobin Sep 7, 2021
22ef58e
Fix formatting
deeprobin Sep 7, 2021
dfdc139
Remove last Environment.Is64BitProcess check
deeprobin Sep 7, 2021
0a70ec5
Add tests
deeprobin Sep 7, 2021
177c8e8
Remove [CLSCompliant(false)] Attribute from BitOperations which use n…
deeprobin Sep 8, 2021
cb93349
Add refs
deeprobin Sep 10, 2021
716e874
Add refs
deeprobin Sep 10, 2021
7f79d99
Fix RotateLeft and RotateRight test
deeprobin Sep 10, 2021
c5a7ae0
Add IgnoreOnArchitectureTheoryAttribute and remove checks for not exi…
deeprobin Sep 11, 2021
87024e7
Replace custom TheoryAttribute with ConditionalTheory
deeprobin Sep 13, 2021
7a826ca
Add unchecked syntax due CS8778
deeprobin Sep 13, 2021
21a6eb3
Fix parameter type in BitOperationsTests.BitOps_RoundUpToPow2_nuint_64
deeprobin Sep 15, 2021
f157dfc
Fix Test values
deeprobin Sep 15, 2021
2baf92c
Fix expectation parameter
deeprobin Sep 16, 2021
21054db
Fix 32-bit expectation
deeprobin Sep 16, 2021
5e89bd3
Fix 32-bit test
deeprobin Sep 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Change access modifier of BitOperations.IsPow2
  • Loading branch information
@deeprobin
deeprobin committed Sep 6, 2021
commit 2bbb78c74d1d63b6514874acdaa15c4fc154262a
7 changes: 3 additions & 4 deletions src/libraries/System.Private.CoreLib/src/System/Numerics/BitOperations.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,14 +76,14 @@ public static class BitOperations
/// </summary>
/// <param name="value">The value.</param>
[MethodImpl(MethodImplOptions.AggressiveInlining)]
internal static bool IsPow2(nint value) => (value & (value - 1)) == 0 && value > 0;
public static bool IsPow2(nint value) => (value & (value - 1)) == 0 && value > 0;

/// <summary>
/// Evaluate whether a given integral value is a power of 2.
/// </summary>
/// <param name="value">The value.</param>
[MethodImpl(MethodImplOptions.AggressiveInlining)]
internal static bool IsPow2(nuint value) => (value & (value - 1)) == 0 && value != 0;
public static bool IsPow2(nuint value) => (value & (value - 1)) == 0 && value != 0;

/// <summary>Round the given integral value up to a power of 2.</summary>
/// <param name="value">The value.</param>
Expand All @@ -105,7 +105,7 @@ public static uint RoundUpToPowerOf2(uint value)
#endif
}

// Based on https://graphics.stanford.edu/~seander/bithacks.html#RoundUpPowerOf2
// Based on
--value;
value |= value >> 1;
value |= value >> 2;
Expand All @@ -115,7 +115,6 @@ public static uint RoundUpToPowerOf2(uint value)
return value + 1;
}


/// <summary>
/// Round the given integral value up to a power of 2.
/// </summary>
Expand Down