Thanks to visit codestin.com
Credit goes to github.com

Skip to content

JIT: Support delegate GDV guards in loop cloning #75140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Oct 20, 2022
Merged

JIT: Support delegate GDV guards in loop cloning #75140

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
a5afa33
JIT: Support delegate GDV guards in loop cloning
jakobbotsch Sep 6, 2022
9867d1d
Minor clean ups
jakobbotsch Sep 6, 2022
3069d12
Fix x86 build
jakobbotsch Sep 6, 2022
1c34ec1
Run jit-format
jakobbotsch Sep 7, 2022
17169ab
Remove FG opts
jakobbotsch Sep 7, 2022
cab5b3f
Readd some code, add function headers
jakobbotsch Sep 7, 2022
9a53262
Print in base 10
jakobbotsch Sep 9, 2022
03cdacb
Remove reuse temp logic, small cleanups
jakobbotsch Sep 14, 2022
b57ab02
Merge branch 'main' of github.com:dotnet/runtime into delegate-gdv-lo…
jakobbotsch Oct 14, 2022
975a07c
Merge branch 'main' of github.com:dotnet/runtime into delegate-gdv-lo…
jakobbotsch Oct 19, 2022
b9ca3db
Remove exceptions on indirs in guards after loop cloning
jakobbotsch Oct 19, 2022
a569adf
Add some JitDump
jakobbotsch Oct 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Minor clean ups
  • Loading branch information
@jakobbotsch
jakobbotsch committed Sep 6, 2022
commit 9867d1d1fb86f29ef2d00ab20e83f6f73526bd06
1 change: 0 additions & 1 deletion src/coreclr/jit/indirectcalltransformer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,7 +547,6 @@ class IndirectCallTransformer
if (thisTree->IsLocal())
{
thisTree = compiler->gtCloneExpr(thisTree);
LclVarDsc* dsc = compiler->lvaGetDesc(thisTree->AsLclVarCommon());
}
else
{
Expand Down
4 changes: 1 addition & 3 deletions src/coreclr/jit/loopcloning.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2821,7 +2821,7 @@ Compiler::fgWalkResult Compiler::optCanOptimizeByLoopCloning(GenTree* tree, Loop
GenTree* relopOp1 = relop->AsOp()->gtGetOp1();
GenTree* relopOp2 = relop->AsOp()->gtGetOp2();

// One side or the other must be an indir and the other must be a loop
// One side or the other must be an indir and the other must be loop
// invariant. Currently, we'll just look for a constant or indir of a
// constant. Start out by normalizing it to the right.
//
Expand Down Expand Up @@ -2882,8 +2882,6 @@ Compiler::fgWalkResult Compiler::optCanOptimizeByLoopCloning(GenTree* tree, Loop
}
else if (optIsHandleOrIndirOfHandle(relopOp2, GTF_ICON_FTN_ADDR))
{
// The indir addr must be loop invariant TYP_REF local
//
GenTree* indirAddr = relopOp1->AsIndir()->Addr();

// ▌ JTRUE void
Expand Down