Fix prefix writing on TarHeaderWrite #75350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsThis PR takes the fix from #75023 but add tests that don't use the tar tool which is currently hard to get right on all CI configurations.
|
|
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsThis PR takes the fix from #75023 but add tests that don't use the tar tool which is currently hard to get right on all CI configurations.
|
carlossanlop
approved these changes
Sep 9, 2022
jozkee
commented
Sep 9, 2022
Comment on lines
305
to
307
| // On reading, ustar just combines prefix(155) + '/' + name(100), which may be wrong but that's how it currently is. | ||
| // On writing, it writes the first 100 chars of entryName on name and the next 155 on prefix, so it is flipping the name+prefix on reading. | ||
| //[InlineData(TarEntryFormat.Ustar)] |
There was a problem hiding this comment.
Suggested change
| // On reading, ustar just combines prefix(155) + '/' + name(100), which may be wrong but that's how it currently is. | |
| // On writing, it writes the first 100 chars of entryName on name and the next 155 on prefix, so it is flipping the name+prefix on reading. | |
| //[InlineData(TarEntryFormat.Ustar)] | |
| // [InlineData(TarEntryFormat.Ustar)] https://github.com/dotnet/runtime/issues/75360 |
|
/backport to release/7.0 |
|
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3025402757 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes the fix from #75023 but add tests that don't use the tar tool which is currently hard to get right on all CI configurations.