Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Implement IEEE754 totalOrder comparer #75517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Sep 24, 2022
Merged

Implement IEEE754 totalOrder comparer #75517

merged 18 commits into from
Sep 24, 2022

Conversation

huoyaoyuan
Copy link
Member

Closes #73583

@ghost
Copy link

ghost commented Sep 13, 2022

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Sep 13, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Sep 13, 2022
@ghost
Copy link

ghost commented Sep 13, 2022

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

Issue Details

Closes #73583

Author: huoyaoyuan
Assignees: -
Labels:

area-System.Numerics, new-api-needs-documentation, community-contribution
Milestone: -

@huoyaoyuan
Copy link
Member Author

CI Failure looks unrelated

huoyaoyuan
huoyaoyuan commented Sep 21, 2022
View reviewed changes
dakersnar
dakersnar reviewed Sep 21, 2022
View reviewed changes
Copy link
Contributor

@dakersnar dakersnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, agree with Tanner's suggestions. Thanks for the contribution!

dakersnar
dakersnar approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@dakersnar dakersnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, need a secondary review from @tannergooding.

tannergooding
tannergooding approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@tannergooding tannergooding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to confirm the last open piece of feedback from Stephen, then can merge.

@huoyaoyuan
Copy link
Member Author

huoyaoyuan commented Sep 24, 2022 •
edited
Loading

The failure looks unrelated. Trigger a rerun?

Looks like #76041

@tannergooding
Copy link
Member

Looks like #76041

Indeed.

@tannergooding tannergooding merged commit baab095 into dotnet:main Sep 24, 2022
@huoyaoyuan huoyaoyuan deleted the total-order branch September 25, 2022 04:17
@ghost ghost locked as resolved and limited conversation to collaborators Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub left review comments

@tannergooding tannergooding tannergooding approved these changes

+1 more reviewer

@dakersnar dakersnar dakersnar approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area-System.Numerics community-contribution Indicates that the PR has been added by a community member new-api-needs-documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[API Proposal]: Modify Float/Double Equals and CompareTo to reflect -0.0 and +0.0 difference and ordering
4 participants
@huoyaoyuan @tannergooding @stephentoub @dakersnar