Thanks to visit codestin.com
Credit goes to github.com

Skip to content

HttpStress do not use SYS_PTRACE cap for docker runs #76307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 4, 2022
Merged

HttpStress do not use SYS_PTRACE cap for docker runs #76307

merged 5 commits into from
Oct 4, 2022

Conversation

antonfirsov
Copy link
Member

@antonfirsov antonfirsov commented Sep 28, 2022 •
edited
Loading

According to an offline discussion with engineering folks, there is no need for SYS_PTRACE on newer Linux kernels, so we can remove it for all platforms.

The PR is marked as draft because it contains an emulated crash to test dump creation. If everything works fine, I will remove it.

Fixes #76045

@antonfirsov antonfirsov added this to the 8.0.0 milestone Sep 28, 2022
@antonfirsov antonfirsov marked this pull request as draft September 28, 2022 14:53
@ghost ghost assigned antonfirsov Sep 28, 2022
@ghost
Copy link

ghost commented Sep 28, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

According to an offline discussion with engineering folks, there is no need for SYS_PTRACE on newer Linux kernels, so we can remove it for all platforms.

The PR is marked as draft because it contains an emulated crash to test dump creation. If everything works fine, I will remove it.

Fixes #76045

Author: antonfirsov
Assignees: -
Labels:

area-System.Net.Http
Milestone: 8.0.0

@antonfirsov
Revert "remove SYS_PTRACE"
956e887 
This reverts commit 8cdfad5.
@antonfirsov
Copy link
Member Author

The artifacts zip-s contain empty folders even after my undo commit 956e887:
https://dev.azure.com/dnceng-public/public/_build/results?buildId=33787&view=artifacts&pathAsName=false&type=publishedArtifacts

I think we should go ahead with the capability removal and investigate the artifact creation issues later.

@dotnet dotnet deleted a comment from azure-pipelines bot Sep 28, 2022
@dotnet dotnet deleted a comment from azure-pipelines bot Sep 28, 2022
@azure-pipelines

This comment was marked as resolved.

Sign in to view
@dotnet dotnet deleted a comment from azure-pipelines bot Sep 28, 2022
ManickaP
ManickaP approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@antonfirsov
Copy link
Member Author

/azp run runtime-libraries stress-http

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@antonfirsov antonfirsov marked this pull request as ready for review October 4, 2022 15:33
@antonfirsov antonfirsov changed the title [WIP] HttpStress do not use SYS_PTRACE cap for docker runs HttpStress do not use SYS_PTRACE cap for docker runs Oct 4, 2022
@antonfirsov antonfirsov merged commit fd770d5 into dotnet:main Oct 4, 2022
@antonfirsov
Copy link
Member Author

/backport to release/7.0

@github-actions
Copy link
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3267925204

@github-actions github-actions bot mentioned this pull request Oct 17, 2022
Merged
@antonfirsov antonfirsov mentioned this pull request Oct 17, 2022
Open
@ghost ghost locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ManickaP ManickaP ManickaP approved these changes

Assignees

@antonfirsov antonfirsov

Labels
area-System.Net.Http
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

HttpStress is broken on Windows (CAP_SYS_PTRACE)
2 participants
@antonfirsov @ManickaP