-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[mono][sgen] Update memory load information after world is resumed #76400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Following recent cgroup support, mono_determine_physical_ram_size is no longer safe to call during GC.
Tagging subscribers to this area: @BrzVlad Issue DetailsFollowing recent cgroup support (#74237), mono_determine_physical_ram_size is no longer safe to call during GC.
|
@nealef @akoeplinger Any idea if this impacts android ? |
What part of #74237 makes it unsafe to call |
The new code explicitly excludes Android. That is, it uses the previous code path. |
@naricc |
I didn't realize we query the ram size on each GC stw cycle, do we know if the cgroup additions have any perf impact? We'll also need to backport this to 7.0 since we backported the cgroup change. |
I have not seen any perf regressions that I could attribute to this, although the microbenchmarks are so micro I am not sure how many of them exercise the GC much. There was also some missing data on some platforms around the time this was merged. |
Failures are unrelated. |
/backport to release/7.0 |
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3174227750 |
Following recent cgroup support (#74237), mono_determine_physical_ram_size is no longer safe to call during GC.