Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use IndexOf to find closing quote in WarningHeaderValue #76804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Use IndexOf to find closing quote in WarningHeaderValue #76804

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions src/libraries/System.Net.Http/src/System/Net/Http/Headers/WarningHeaderValue.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,19 +280,12 @@ private static bool TryReadDate(string input, ref int current, out DateTimeOffse

// Find the closing '"'
int dateStartIndex = current;
while (current < input.Length)
int quote = input.AsSpan(current).IndexOf('"');
if (quote <= 0) // no quote was found or it was the first character (meaning an empty quoted string)
{
if (input[current] == '"')
{
break;
}
current++;
}

if ((current == input.Length) || (current == dateStartIndex))
{
return false; // we couldn't find the closing '"' or we have an empty quoted string.
return false;
}
current += quote;

DateTimeOffset temp;
if (!HttpDateParser.TryParse(input.AsSpan(dateStartIndex, current - dateStartIndex), out temp))
Expand Down