Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Cache GenericTypeDefinition to improve perf #78288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 22, 2022
Merged

Cache GenericTypeDefinition to improve perf #78288

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
74e0d20
Put GenericTypeDefinition into genericCache.
lateapexearlyspeed Nov 13, 2022
b910385
Fix comment: change to use MT flags to check nullability.
lateapexearlyspeed Nov 17, 2022
6efb63e
Not worth caching IsNullableOfT anymore
jkotas Nov 19, 2022
39f1e9e
Merge branch 'main' into lateapexearlyspeed-CacheGenericDefinition
jkotas Nov 20, 2022
b7c990b
Factor out the slow path into a non-inlineable method
jkotas Nov 20, 2022
e87a8f6
Port a few generic-related RuntimeType fcalls to C#
jkotas Nov 20, 2022
5e0504d
Add comment
jkotas Nov 20, 2022
05afc32
Use seperate cache field for the type definition
jkotas Nov 20, 2022
cba70f2
Tweak IsConstructedGenericType
jkotas Nov 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Factor out the slow path into a non-inlineable method
  • Loading branch information
@jkotas
jkotas committed Nov 20, 2022
commit b7c990b6305b027d59bab2b65b8dd0e957c31c17
21 changes: 10 additions & 11 deletions src/coreclr/System.Private.CoreLib/src/System/RuntimeHandles.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -689,20 +689,19 @@ internal RuntimeType MakePointer()

internal static RuntimeType GetGenericTypeDefinition(RuntimeType type)
{
if (HasInstantiation(type) && !IsGenericTypeDefinition(type))
{
if (type.GenericCache is not RuntimeType genericDefinition)
{
RuntimeTypeHandle nativeHandle = type.TypeHandle;
genericDefinition = null!;
GetGenericTypeDefinition(new QCallTypeHandle(ref nativeHandle), ObjectHandleOnStack.Create(ref genericDefinition));
type.GenericCache = genericDefinition;
}
Debug.Assert(HasInstantiation(type));

return IsGenericTypeDefinition(type) ? type :
type.GenericCache is RuntimeType genericDefinition ? genericDefinition : CacheGenericDefinition(type);

[MethodImpl(MethodImplOptions.NoInlining)]
static RuntimeType CacheGenericDefinition(RuntimeType type)
{
RuntimeType genericDefinition = null!;
GetGenericTypeDefinition(new QCallTypeHandle(ref type), ObjectHandleOnStack.Create(ref genericDefinition));
type.GenericCache = genericDefinition;
return genericDefinition;
}

return type;
}

[MethodImpl(MethodImplOptions.InternalCall)]
Expand Down