Fix ALC lookup from the DAC #78400
Merged
Fix ALC lookup from the DAC #78400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems the SOS commands for ALC lookup have been broken for a bit. Some parts of the impl weren't DAC-ized and caused failures.
|
Tagging subscribers to this area: @tommcdon Issue DetailsIt seems the SOS commands for ALC lookup have Fixes issue found in dotnet/diagnostics#3508 We should also backport this to .NET 7. /cc @hoyosjs @dotnet/dotnet-diag-contrib @janvorli
|
hoyosjs
approved these changes
Nov 15, 2022
|
/backport to release/7.0 |
|
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3473917722 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems the SOS commands for ALC lookup have
been broken for a bit. Some parts of the impl
weren't DAC-ized and caused failures.
Fixes issue found in dotnet/diagnostics#3508
We should also backport this to .NET 7.
/cc @hoyosjs @dotnet/dotnet-diag-contrib @janvorli @elinor-fung