Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Intrinsify Interlocked.CompareExchange and Interlocked.Exchange for null #79181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 5, 2022
Merged

Intrinsify Interlocked.CompareExchange and Interlocked.Exchange for null #79181

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a0d1e1c
Intrinsify Interlocked.CompareExchange and Interlocked.Exchange for null
EgorBo Dec 3, 2022
401177a
Address feedback
EgorBo Dec 3, 2022
923236d
Merge branch 'main' of github.com:dotnet/runtime into intrinsify-inte…
EgorBo Dec 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/coreclr/System.Private.CoreLib/src/System/Threading/Interlocked.CoreCLR.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ public static long Decrement(ref long location) =>
/// <param name="value">The value to which the <paramref name="location1"/> parameter is set.</param>
/// <returns>The original value of <paramref name="location1"/>.</returns>
/// <exception cref="NullReferenceException">The address of location1 is a null pointer.</exception>
[Intrinsic]
[MethodImpl(MethodImplOptions.InternalCall)]
[return: NotNullIfNotNull(nameof(location1))]
public static extern object? Exchange([NotNullIfNotNull(nameof(value))] ref object? location1, object? value);
Expand Down Expand Up @@ -145,6 +146,7 @@ public static T Exchange<T>([NotNullIfNotNull(nameof(value))] ref T location1, T
/// <param name="comparand">The object that is compared by reference to the object at <paramref name="location1"/>.</param>
/// <returns>The original value in <paramref name="location1"/>.</returns>
/// <exception cref="NullReferenceException">The address of <paramref name="location1"/> is a null pointer.</exception>
[Intrinsic]
[MethodImpl(MethodImplOptions.InternalCall)]
[return: NotNullIfNotNull(nameof(location1))]
public static extern object? CompareExchange(ref object? location1, object? value, object? comparand);
Expand Down
2 changes: 1 addition & 1 deletion src/coreclr/jit/codegenxarch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4064,7 +4064,7 @@ void CodeGen::genLockedInstructions(GenTreeOp* node)

assert(addr->isUsedFromReg());
assert(data->isUsedFromReg());
assert((size == EA_4BYTE) || (size == EA_PTRSIZE));
assert((size == EA_4BYTE) || (size == EA_PTRSIZE) || (size == EA_GCREF));

genConsumeOperands(node);

Expand Down
9 changes: 8 additions & 1 deletion src/coreclr/jit/emitxarch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12193,7 +12193,14 @@ BYTE* emitter::emitOutputAM(BYTE* dst, instrDesc* id, code_t code, CnsVal* addc)

case IF_ARW_RRD:
case IF_ARW_CNS:
assert(id->idGCref() == GCT_BYREF && (ins == INS_add || ins == INS_sub || ins == INS_sub_hide));
if (id->idGCref() == GCT_BYREF)
{
assert(ins == INS_add || ins == INS_sub || ins == INS_sub_hide);
}
else
{
assert((id->idGCref() == GCT_GCREF) && (ins == INS_cmpxchg || ins == INS_xchg));
}
break;

default:
Expand Down
14 changes: 12 additions & 2 deletions src/coreclr/jit/importercalls.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2967,7 +2967,12 @@ GenTree* Compiler::impIntrinsic(GenTree* newobjThis,
{
break;
}
if ((retType != TYP_INT) && (retType != TYP_LONG))
if ((retType == TYP_REF) && impStackTop().val->IsIntegralConst(0))
{
// Intrinsify "object" overload in case of null assignment
// since we don't need the write barrier.
}
else if ((retType != TYP_INT) && (retType != TYP_LONG))
{
break;
}
Expand Down Expand Up @@ -2997,7 +3002,12 @@ GenTree* Compiler::impIntrinsic(GenTree* newobjThis,
{
break;
}
if ((retType != TYP_INT) && (retType != TYP_LONG))
if ((retType == TYP_REF) && impStackTop().val->IsIntegralConst(0))
{
// Intrinsify "object" overload in case of null assignment
// since we don't need the write barrier.
}
else if ((retType != TYP_INT) && (retType != TYP_LONG))
{
break;
}
Expand Down