Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[release/7.0][wasm] Add RollForward=Major for WasmAppHost . #79315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 4, 2023
Merged

[release/7.0][wasm] Add RollForward=Major for WasmAppHost . #79315

merged 2 commits into from
Jan 4, 2023

Conversation

radical
Copy link
Member

@radical radical commented Dec 6, 2022 •
edited
Loading

Customer impact

WasmAppHost is used to run apps created with wasm templates. This fix allows such projects that target net7.0 to be run with 8.0 SDK.

Fixes #79313

Testing

Unit tests, and manual testing.

Risk

Low.

@radical
[wasm] Add RollForward=LatestMajor for WasmAppHost .
77f2d74 
This fixes running apps targeting net7.0 to run with 8.0 sdk.

Fixes dotnet#79313
@radical radical added arch-wasm WebAssembly architecture area-Build-mono labels Dec 6, 2022
@radical radical added this to the 7.0.x milestone Dec 6, 2022
@ghost ghost assigned radical Dec 6, 2022
@ghost
Copy link

ghost commented Dec 6, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

This fixes running apps targeting net7.0 to run with 8.0 sdk.

Fixes #79313

Author: radical
Assignees: -
Labels:

arch-wasm, area-Build-mono
Milestone: 7.0.x

@radical radical marked this pull request as ready for review December 7, 2022 05:24
@radical radical added the Servicing-consider Issue for next servicing release review label Dec 7, 2022
@radical radical requested a review from akoeplinger December 7, 2022 05:24
@akoeplinger
Copy link
Member

I think Major would be the more correct setting, we use that in other cases.

@radical radical changed the title [release/7.0][wasm] Add RollForward=LatestMajor for WasmAppHost . [release/7.0][wasm] Add RollForward=Major for WasmAppHost . Dec 7, 2022
@runfoapp runfoapp bot mentioned this pull request Dec 7, 2022
Closed
@marek-safar marek-safar added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Dec 8, 2022
@carlossanlop carlossanlop modified the milestones: 7.0.x, 7.0.3 Jan 4, 2023
@carlossanlop
Copy link
Contributor

Approved by Tactics for 7.0.3.
Signed off by area owner.
No OOB changes needed.
Feedback addressed ("Major").
CI failures: one is known/unrelated/already fixed: #78778. The other one seems unrelated to this change (minijit/windows).
Ready to merge. :shipit:

@carlossanlop carlossanlop merged commit 4fc39fe into dotnet:release/7.0 Jan 4, 2023
@radical radical deleted the rollforward7 branch January 31, 2023 18:40
@ghost ghost locked as resolved and limited conversation to collaborators Mar 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@pavelsavara pavelsavara Awaiting requested review from pavelsavara pavelsavara is a code owner

Assignees

@radical radical

Labels
arch-wasm WebAssembly architecture area-Build-mono Servicing-approved Approved for servicing release
Projects
None yet
Milestone
7.0.3
Development

Successfully merging this pull request may close these issues.
4 participants
@radical @akoeplinger @carlossanlop @marek-safar