Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Only allocate StringBuilder for complex type names #79325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 7, 2022
Merged

Only allocate StringBuilder for complex type names #79325

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1ac365f
Only allocate StringBuilder for complex type names
benaadams Dec 7, 2022
c18613a
Reuse function
benaadams Dec 7, 2022
2d8adf8
Update src/libraries/Common/src/Extensions/TypeNameHelper/TypeNameHel…
benaadams Dec 7, 2022
07824ba
Nullability
benaadams Dec 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 25 additions & 7 deletions src/libraries/Common/src/Extensions/TypeNameHelper/TypeNameHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,43 +49,61 @@ internal static class TypeNameHelper
/// <returns>The pretty printed type name.</returns>
public static string GetTypeDisplayName(Type type, bool fullName = true, bool includeGenericParameterNames = false, bool includeGenericParameters = true, char nestedTypeDelimiter = DefaultNestedTypeDelimiter)
{
var builder = new StringBuilder();
ProcessType(builder, type, new DisplayNameOptions(fullName, includeGenericParameterNames, includeGenericParameters, nestedTypeDelimiter));
return builder.ToString();
StringBuilder? builder = null;
string? name = ProcessType(ref builder, type, new DisplayNameOptions(fullName, includeGenericParameterNames, includeGenericParameters, nestedTypeDelimiter));
return name ?? builder?.ToString() ?? string.Empty;
}

private static void ProcessType(StringBuilder builder, Type type, in DisplayNameOptions options)
private static string? ProcessType(ref StringBuilder? builder, Type type, in DisplayNameOptions options)
{
if (type.IsGenericType)
{
Type[] genericArguments = type.GetGenericArguments();
builder ??= new StringBuilder();
ProcessGenericType(builder, type, genericArguments, genericArguments.Length, options);
}
else if (type.IsArray)
{
builder ??= new StringBuilder();
ProcessArrayType(builder, type, options);
}
else if (_builtInTypeNames.TryGetValue(type, out string? builtInName))
{
if (builder is null) return builtInName;

builder.Append(builtInName);
}
else if (type.IsGenericParameter)
{
if (options.IncludeGenericParameterNames)
{
if (builder is null) return type.Name;

builder.Append(type.Name);
}
}
else
{
string name = options.FullName ? type.FullName! : type.Name;
builder.Append(name);

if (builder is null)
{
if (options.NestedTypeDelimiter != DefaultNestedTypeDelimiter)
{
return name.Replace(DefaultNestedTypeDelimiter, options.NestedTypeDelimiter);
}

return name;
}

builder.Append(name);
if (options.NestedTypeDelimiter != DefaultNestedTypeDelimiter)
{
builder.Replace(DefaultNestedTypeDelimiter, options.NestedTypeDelimiter, builder.Length - name.Length, name.Length);
}
}

return null;
}

private static void ProcessArrayType(StringBuilder builder, Type type, in DisplayNameOptions options)
Expand All @@ -96,7 +114,7 @@ private static void ProcessArrayType(StringBuilder builder, Type type, in Displa
innerType = innerType.GetElementType()!;
}

ProcessType(builder, innerType, options);
ProcessType(ref builder!, innerType, options);

while (type.IsArray)
{
Expand Down Expand Up @@ -143,7 +161,7 @@ private static void ProcessGenericType(StringBuilder builder, Type type, Type[]
builder.Append('<');
for (int i = offset; i < length; i++)
{
ProcessType(builder, genericArguments[i], options);
ProcessType(ref builder!, genericArguments[i], options);
if (i + 1 == length)
{
continue;
Expand Down