Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use IndexOfAnyExceptInRange in ZipHelper.GetEncoding #79357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Use IndexOfAnyExceptInRange in ZipHelper.GetEncoding #79357

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/libraries/System.IO.Compression/src/System/IO/Compression/ZipHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,16 +22,14 @@ internal static class ZipHelper

internal static Encoding GetEncoding(string text)
{
foreach (char c in text)
if (text.AsSpan().IndexOfAnyExceptInRange((char)32, (char)126) >= 0)
{
// The Zip Format uses code page 437 when the Unicode bit is not set. This format
// is the same as ASCII for characters 32-126 but differs otherwise. If we can fit
// the string into CP437 then we treat ASCII as acceptable.
if (c > 126 || c < 32)
{
return Encoding.UTF8;
}
return Encoding.UTF8;
}

return Encoding.ASCII;
}

Expand Down