Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[mono][debugger] Fix Debugger.Break() behavior when running on release mode #79822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2022
Merged

[mono][debugger] Fix Debugger.Break() behavior when running on release mode #79822

merged 1 commit into from
Dec 20, 2022

Conversation

thaystg
Copy link
Member

@thaystg thaystg commented Dec 19, 2022

If native_debugger_break is disabled do not call G_BREAKPOINT otherwise the app will be interrupted by a signal when running in release mode a code that has a Debugger.Break()

Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1675269

@thaystg thaystg requested review from lewing and lambdageek December 19, 2022 16:17
@thaystg thaystg requested a review from marek-safar as a code owner December 19, 2022 16:17
@ghost ghost added the area-Debugger-mono label Dec 19, 2022
@ghost ghost assigned thaystg Dec 19, 2022
@ghost
Copy link

ghost commented Dec 19, 2022

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

If native_debugger_break is disabled do not call G_BREAKPOINT otherwise the app will be interrupted by a signal when running in release mode a code that has a Debugger.Break()

Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1675269

Author: thaystg
Assignees: -
Labels:

area-Debugger-mono
Milestone: -

@thaystg thaystg changed the title [mono][debugger]Fixing generating a signal when running on release mode [mono][debugger] Fix Debugger.Break() behavior when running on release mode Dec 19, 2022
@build-analysis build-analysis bot mentioned this pull request Dec 19, 2022
Closed
@thaystg
Copy link
Member Author

thaystg commented Dec 20, 2022

@steveisok should we backport this one?

@thaystg thaystg merged commit 90c7986 into dotnet:main Dec 20, 2022
@thaystg
Copy link
Member Author

thaystg commented Jan 11, 2023

@lewing should we backport this one?

@steveisok
Copy link
Member

Yes, I think so as long as @lewing is ok w/ it.

@thaystg
Copy link
Member Author

thaystg commented Jan 11, 2023

/backport to release/7.0

@github-actions
Copy link
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3893630409

@github-actions github-actions bot mentioned this pull request Jan 11, 2023
Merged
@lambdageek
Copy link
Member

@thaystg Should we backport this to 6.0, too?

runtime/src/mono/mono/component/debugger-stub.c

Lines 156 to 159 in ace6275

stub_debugger_user_break (void)
{
G_BREAKPOINT ();
}

@thaystg
Copy link
Member Author

thaystg commented Jan 13, 2023

@thaystg Should we backport this to 6.0, too?

runtime/src/mono/mono/component/debugger-stub.c

Lines 156 to 159 in ace6275

stub_debugger_user_break (void)
{
G_BREAKPOINT ();
}

I think so. I will open it. :)

@thaystg thaystg mentioned this pull request Jan 13, 2023
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Feb 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lewing lewing lewing approved these changes

@lambdageek lambdageek Awaiting requested review from lambdageek

@marek-safar marek-safar Awaiting requested review from marek-safar

Assignees

@thaystg thaystg

Labels
area-Debugger-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thaystg @steveisok @lambdageek @lewing