Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Improve the performance of ConditionalWeakTable.TryGetValue #80059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jan 5, 2023
Merged

Improve the performance of ConditionalWeakTable.TryGetValue #80059

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
bd618d4
[NativeAOT] Fix Objective-C reference tracking
AustinWise Dec 29, 2022
ce38802
Move implementation-specific comment out of public doc comment
AustinWise Dec 30, 2022
9967b1f
Duplicate code for TryGetHashCode implementations.
AustinWise Dec 30, 2022
07bb690
Replace comments with a passing test.
AustinWise Dec 30, 2022
6a13d23
Add moke test for restricted callouts.
AustinWise Dec 30, 2022
d9a6dc2
Remove TryGetHashCode from Mono
AustinWise Dec 30, 2022
cd22146
Update src/tests/Interop/ObjectiveC/ObjectiveCMarshalAPI/Program.cs
AustinWise Dec 30, 2022
2131f4d
Update src/libraries/System.Private.CoreLib/src/System/Runtime/Compil…
AustinWise Dec 30, 2022
129eee0
Revert "Add moke test for restricted callouts."
AustinWise Dec 30, 2022
e81000f
Add test coverage for untracked objective objects.
AustinWise Dec 30, 2022
2eaed50
Spelling
AustinWise Dec 30, 2022
1ccbe61
Implement RuntimeHelpers.TryGetHashCode for Mono
AustinWise Dec 31, 2022
84d8c40
Remove unneeded MONO_COMPONENT_API
AustinWise Jan 1, 2023
58f3667
Remove Mono intrinsic for InternalGetHashCode
AustinWise Jan 2, 2023
1d94c9c
Move interpreter transforms to correct class.
AustinWise Jan 2, 2023
93f22e1
Rename and move icall to match convention.
AustinWise Jan 2, 2023
4d65fa4
Merge remote-tracking branch 'origin/main' into austin/TryGetHashCode
AustinWise Jan 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove TryGetHashCode from Mono 
It does not guarantee that hash codes are non-zero.
  • Loading branch information
@AustinWise
AustinWise committed Dec 30, 2022
commit d9a6dc22b4c3afdb35f450c258ad7c3ffc3011fb
8 changes: 7 additions & 1 deletion ...raries/System.Private.CoreLib/src/System/Runtime/CompilerServices/ConditionalWeakTable.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,7 +538,10 @@ internal int FindEntry(TKey key, out object? value)
{
Debug.Assert(key != null); // Key already validated as non-null.

int hashCode = RuntimeHelpers.TryGetHashCode(key);
int hashCode;

#if CORECLR || NATIVEAOT
hashCode = RuntimeHelpers.TryGetHashCode(key);

if (hashCode == 0)
{
Expand All @@ -547,6 +550,9 @@ internal int FindEntry(TKey key, out object? value)
value = null;
return -1;
}
#else
hashCode = RuntimeHelpers.GetHashCode(key);
#endif

hashCode &= int.MaxValue;
int bucket = hashCode & (_buckets.Length - 1);
Expand Down
6 changes: 0 additions & 6 deletions src/mono/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.Mono.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,6 @@ public static int GetHashCode(object? o)
return InternalGetHashCode(o);
}

internal static int TryGetHashCode(object o)
{
// On Mono the fast path is not yet implemented, so we just defer to GetHashCode.
return InternalGetHashCode(o);
}

public static new bool Equals(object? o1, object? o2)
{
if (o1 == o2)
Expand Down