Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
47be1e2
[wasm] Enable SIMD
radekdoulik Jan 18, 2023
a0fc3eb
Let old V8 use simd
radekdoulik Jan 18, 2023
b695c92
[wasm] ManagedToNativeGenerator: Skip unmanaged dlls
radical Jan 19, 2023
9c0ea37
Merge remote-tracking branch 'origin/main' into pr-wasm-enable-simd
radical Jan 19, 2023
cb53bc6
[wasm] WasmApp.Native.targets: do not trigger relinking when WasmEnab…
radical Jan 19, 2023
68da732
Use staging image with newer v8
radekdoulik Jan 19, 2023
b260375
[wasm] WasmAppHost: Add support for host arguments
radical Jan 20, 2023
d12ab67
[wasm] console template: Add --experimental-wasm-simd to node, and re…
radical Jan 20, 2023
5f68d50
[wasm] Pass --experiment-wasm-simd for aot library tests too
radical Jan 20, 2023
432e144
Merge branch 'pr-wasm-enable-simd' of https://github.com/radekdoulik/…
radical Jan 20, 2023
a15b3ef
Try to pass full path to v8
radekdoulik Jan 20, 2023
033d473
Use docker image for all wasm helix jobs
radekdoulik Jan 20, 2023
5dec1aa
Set DOTNET_CLI_HOME under workitem payload
radekdoulik Jan 23, 2023
80f678a
Revert "Try to pass full path to v8"
radekdoulik Jan 23, 2023
7242ab8
Use DOTNET_SKIP_FIRST_TIME_EXPERIENCE=1
radekdoulik Jan 23, 2023
37080d6
Set NeedsEMSDKNode to false
radekdoulik Jan 23, 2023
7eb08b7
Merge remote-tracking branch 'remotes/origin/main' into pr-wasm-enabl…
radekdoulik Jan 25, 2023
aa544f4
Revert "Set DOTNET_CLI_HOME under workitem payload"
radekdoulik Jan 25, 2023
dc72268
Set DOTNET_CLI_HOME under workitem payload
radekdoulik Jan 23, 2023
9e1640a
Reverse the test here as we don't relink anymore
radekdoulik Jan 31, 2023
ca896d7
Merge remote-tracking branch 'remotes/origin/main' into pr-wasm-enabl…
radekdoulik Jan 31, 2023
b836780
Merge remote-tracking branch 'remotes/origin/main' into pr-wasm-enabl…
radekdoulik Feb 6, 2023
1371cce
Set _ExtraTrimmerArgs for tests
radekdoulik Feb 6, 2023
758d5b6
Put the SIMD/trim related props in separate group
radekdoulik Feb 6, 2023
f736fa5
Add dynamic dependency
radekdoulik Feb 7, 2023
42ce1df
Disable Vector128IsHardwareAcceleratedTest
radekdoulik Feb 7, 2023
d8c5b6f
Merge remote-tracking branch 'remotes/origin/main' into pr-wasm-enabl…
radekdoulik Feb 9, 2023
3c02f89
Disable GenericVectorTests.IsHardwareAcceleratedTest
radekdoulik Feb 9, 2023
c401b52
Disable check_no_intrinsic_cattr in emit_vector_2_3_4
radekdoulik Feb 10, 2023
7e054d8
Merge remote-tracking branch 'remotes/origin/main' into pr-wasm-enabl…
radekdoulik Feb 20, 2023
143a73b
[mono] Disable few quaternion intrinsics
radekdoulik Feb 20, 2023
0114506
Change comparison order
radekdoulik Feb 20, 2023
2e0f09b
Merge remote-tracking branch 'remotes/origin/main' into pr-wasm-enabl…
radekdoulik Feb 21, 2023
d05cb53
Use stable images
radekdoulik Feb 21, 2023
44c4b13
Merge branch 'main' into pr-wasm-enable-simd
radical Feb 25, 2023
aed4dd2
WBT: Add --engine-arg=--experimental-wasm-simd for node, and v8
radical Feb 25, 2023
cfc855e
Do not skip dotnet 1st time experience anymore
radekdoulik Feb 27, 2023
7e5505a
Merge remote-tracking branch 'remotes/origin/main' into pr-wasm-enabl…
radekdoulik Feb 27, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[mono] Disable few quaternion intrinsics
For * and / operators as these are not the same as vector operations.
Opened #82408 to implement
correct ones in future.
  • Loading branch information
radekdoulik committed Feb 20, 2023
commit 143a73bcd33aa32aa5fa0c28ae524251f2d396d6
7 changes: 6 additions & 1 deletion src/mono/mono/mini/simd-intrinsics.c
Original file line number Diff line number Diff line change
Expand Up @@ -2112,10 +2112,15 @@ emit_vector_2_3_4 (MonoCompile *cfg, MonoMethod *cmethod, MonoMethodSignature *f
case SN_op_Multiply:
case SN_op_Subtraction:
case SN_Max:
case SN_Min:
case SN_Min: {
const char *klass_name = m_class_get_name (klass);
// FIXME https://github.com/dotnet/runtime/issues/82408
if (!strcmp (klass_name, "Quaternion") && (id == SN_op_Multiply || id == SN_Multiply || id == SN_op_Division || id == SN_Divide))
return NULL;
if (!(!fsig->hasthis && fsig->param_count == 2 && mono_metadata_type_equal (fsig->ret, type) && mono_metadata_type_equal (fsig->params [0], type) && mono_metadata_type_equal (fsig->params [1], type)))
return NULL;
return emit_simd_ins_for_binary_op (cfg, klass, fsig, args, MONO_TYPE_R4, id);
}
case SN_Dot: {
#if defined(TARGET_ARM64) || defined(TARGET_WASM)
int instc0 = OP_FMUL;
Expand Down