Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Avoid allocations when adding existing items to the blob heap. #81059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 19, 2023
Merged

Avoid allocations when adding existing items to the blob heap. #81059

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3d44ea6
Add `BlobDictionary`.
teo-tsirpanis Jan 23, 2023
0cf8b9c
Use `BlobDictionary` in `MetadataReader` and optimize the simple cases.
teo-tsirpanis Jan 23, 2023
a7b99d4
Optimize adding blobs from UTF-16 strings and from blob builders.
teo-tsirpanis Jan 23, 2023
1011fb3
Delete `ByteSequenceComparer`.
teo-tsirpanis Jan 23, 2023
9483228
Fix compiler errors.
teo-tsirpanis Jan 24, 2023
bb40c67
Clean-up `BlobDictionary`; move it, make it non-generic and streamlin…
teo-tsirpanis Jan 24, 2023
5694dce
Merge branch 'dotnet:main' into srm-blob-opt
teo-tsirpanis Apr 11, 2023
9c62c03
Don't try to copy the blob builder's contents to a stack-allocated bu…
teo-tsirpanis Apr 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Don't try to copy the blob builder's contents to a stack-allocated bu… 
…ffer.

The blob builder's default starting size is 256 bytes; the same as the stack-alllocated buffer, and making it bigger does not have any benefit since such large blobs are rare.
  • Loading branch information
@teo-tsirpanis
teo-tsirpanis committed Apr 11, 2023
commit 9c62c03c156c136afa6bfb66fa06fcaf1287c51a
16 changes: 1 addition & 15 deletions src/libraries/System.Reflection.Metadata/src/System/Reflection/Metadata/BlobBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ public ImmutableArray<byte> ToImmutableArray(int start, int byteCount)
return ImmutableByteArrayInterop.DangerousCreateFromUnderlyingArray(ref array);
}

internal bool TryWriteTo(Span<byte> scratchBuffer, out ReadOnlySpan<byte> buffer)
internal bool TryGetSpan(out ReadOnlySpan<byte> buffer)
{
if (_nextOrPrevious == this)
{
Expand All @@ -328,20 +328,6 @@ internal bool TryWriteTo(Span<byte> scratchBuffer, out ReadOnlySpan<byte> buffer
return true;
}

int count = Count;
if (scratchBuffer.Length <= count)
{
int i = 0;
foreach (var chunk in GetChunks())
{
chunk.Span.CopyTo(scratchBuffer.Slice(i));
i += chunk.Length;
}

buffer = scratchBuffer.Slice(0, count);
return true;
}

buffer = default;
return false;
}
Expand Down
2 changes: 1 addition & 1 deletion ...ystem.Reflection.Metadata/src/System/Reflection/Metadata/Ecma335/MetadataBuilder.Heaps.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,7 @@ public BlobHandle GetOrAddBlob(BlobBuilder value)
Throw.ArgumentNull(nameof(value));
}

if (value.TryWriteTo(stackalloc byte[256], out ReadOnlySpan<byte> buffer))
if (value.TryGetSpan(out ReadOnlySpan<byte> buffer))
{
return GetOrAddBlob(buffer);
}
Expand Down