Thanks to visit codestin.com
Credit goes to github.com

Skip to content

JIT: Expand runtime lookups in a late phase #81635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 71 commits into from
Mar 14, 2023
Merged

JIT: Expand runtime lookups in a late phase #81635

Changes from 1 commit
Commits
Show all changes
71 commits
Select commit Hold shift + click to select a range
2dcd5e4
Expand runtime lookups in a late phase
EgorBo Feb 4, 2023
2c7a4a3
Clean up
EgorBo Feb 4, 2023
5754331
Merge branch 'main' of github.com:dotnet/runtime into expand-runtime-…
EgorBo Feb 5, 2023
dca8140
test
EgorBo Feb 6, 2023
e303869
test2
EgorBo Feb 6, 2023
aa760e5
Merge branch 'main' of github.com:dotnet/runtime into expand-runtime-…
EgorBo Feb 25, 2023
20e79dc
Test
EgorBo Feb 25, 2023
22f34a1
Enable JitDasmWithAlignmentBoundaries in Release
EgorBo Feb 25, 2023
c3681c1
Merge branch 'main' of github.com:dotnet/runtime into expand-runtime-…
EgorBo Feb 25, 2023
2110ec0
clean up
EgorBo Feb 25, 2023
54b224c
Revert "Enable JitDasmWithAlignmentBoundaries in Release"
EgorBo Feb 25, 2023
e4d4944
add hashtable
EgorBo Feb 25, 2023
3e272e0
test
EgorBo Feb 25, 2023
2671e14
Initial version (no dynamic expansion for now)
EgorBo Feb 25, 2023
64ae149
Clean up
EgorBo Feb 25, 2023
d991533
Clean up
EgorBo Feb 26, 2023
e20dd2d
Test
EgorBo Feb 26, 2023
8fc0374
Update BB flags properly
EgorBo Feb 26, 2023
269cb36
Add dynamic expansion path
EgorBo Feb 26, 2023
3c1cb1c
Add dynamic expansion
EgorBo Feb 26, 2023
47524ed
Add comments
EgorBo Feb 26, 2023
05ae42d
Merge branch 'main' of github.com:dotnet/runtime into expand-runtime-…
EgorBo Feb 28, 2023
ba8fdc2
test
EgorBo Feb 28, 2023
5d6cf4a
test #2
EgorBo Feb 28, 2023
ec00f5b
it should be <=
EgorBo Feb 28, 2023
ec893da
Update flowgraph.cpp
EgorBo Feb 28, 2023
f81882f
test 3
EgorBo Feb 28, 2023
d1d0bc8
test 4
EgorBo Mar 1, 2023
eea468a
test 4
EgorBo Mar 1, 2023
3d5d61a
Merge branch 'main' of github.com:dotnet/runtime into expand-runtime-…
EgorBo Mar 2, 2023
9af1079
Test 5
EgorBo Mar 2, 2023
ea3bf76
Clean up
EgorBo Mar 2, 2023
8a2a8ad
Found it!
EgorBo Mar 2, 2023
777def6
fix assert
EgorBo Mar 3, 2023
b18b12e
fix assert
EgorBo Mar 3, 2023
0f7fc3d
Merge branch 'main' of github.com:dotnet/runtime into expand-runtime-…
EgorBo Mar 3, 2023
5eee49b
move to separate file + fix some diff regressions
EgorBo Mar 3, 2023
2ff3799
Clean up, address some of the feedback
EgorBo Mar 3, 2023
11cac11
Address feedback [WIP]
EgorBo Mar 3, 2023
936c7d2
Implement gtSplitTree
jakobbotsch Mar 4, 2023
a982e68
Test
EgorBo Mar 4, 2023
aad1188
fix Release
EgorBo Mar 4, 2023
f3853a7
Fix assert
EgorBo Mar 4, 2023
f2d22fe
Initial clean up
EgorBo Mar 5, 2023
3e3b15f
Mark ArrayStack ctor explicit
jakobbotsch Mar 5, 2023
0f40259
Add docs to gtSplitTree
jakobbotsch Mar 5, 2023
2a29ac3
Fix up ASG(COMMA(...), ...) handling
jakobbotsch Mar 5, 2023
598ff71
Split out uses in execution order instead
jakobbotsch Mar 5, 2023
733fcd9
Remove dead local
jakobbotsch Mar 5, 2023
a62a135
Clean up
EgorBo Mar 5, 2023
730ed35
Avoid creating statements for non address-exposed locals
jakobbotsch Mar 5, 2023
9c6c89f
More cleanup (use callUse)
EgorBo Mar 5, 2023
f2c1508
use old path for tier0 (slightly better CQ/TP for tier0)
EgorBo Mar 5, 2023
c1cc980
Code clean up
EgorBo Mar 5, 2023
6f587df
Merge branch 'main' of github.com:dotnet/runtime into expand-runtime-…
EgorBo Mar 11, 2023
2834318
resolve conflicts
EgorBo Mar 11, 2023
79b5076
Update runtimelookup.cpp
EgorBo Mar 12, 2023
f0f14a7
Update src/coreclr/jit/runtimelookup.cpp
EgorBo Mar 12, 2023
6061fa7
Merge branch 'main' of github.com:dotnet/runtime into expand-runtime-…
EgorBo Mar 13, 2023
2a3d83b
Mitigate some tier0 regressions
EgorBo Mar 13, 2023
07cf9e7
clone fastpath for tier0
EgorBo Mar 13, 2023
3a3f4ca
Remove redundant impSpillSideEffects
EgorBo Mar 13, 2023
8af93a9
test
EgorBo Mar 14, 2023
afe2dd4
Fix regressions
EgorBo Mar 14, 2023
7909435
fix tp regressions
EgorBo Mar 14, 2023
258cbae
Apply suggestions from code review
EgorBo Mar 14, 2023
1afb6f8
Address feedback
EgorBo Mar 14, 2023
a116695
Add goto SCAN_BLOCK_AGAIN
EgorBo Mar 14, 2023
386446e
Update src/coreclr/jit/runtimelookup.cpp
EgorBo Mar 14, 2023
d2f3fec
Address feedback
EgorBo Mar 14, 2023
19034d9
update side effects for fallbackBb
EgorBo Mar 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clean up
  • Loading branch information
@EgorBo
EgorBo committed Feb 25, 2023
commit 64ae1497521c330dc97a10b6f1a580be20a35bae
28 changes: 14 additions & 14 deletions src/coreclr/jit/flowgraph.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,28 +196,28 @@ PhaseStatus Compiler::fgExpandRuntimeLookups()
handleForNullCheck->gtFlags |= GTF_IND_NONFAULTING;

GenTree* nullcheckOp = gtNewOperNode(GT_NE, TYP_INT, handleForNullCheck, gtNewIconNode(0, TYP_I_IMPL));
nullcheckOp->gtFlags |= (GTF_RELOP_JMP_USED);
nullcheckOp->gtFlags |= GTF_RELOP_JMP_USED;
gtSetEvalOrder(nullcheckOp);
Statement* nullcheckStmt = fgNewStmtFromTree(gtNewOperNode(GT_JTRUE, TYP_VOID, nullcheckOp));
gtSetStmtInfo(nullcheckStmt);
fgSetStmtSeq(nullcheckStmt);
fgInsertStmtAtEnd(nullcheckBb, nullcheckStmt);

BasicBlock* fastPathBb = fgNewBBafter(BBJ_ALWAYS, nullcheckBb, true);
fastPathBb->bbFlags |= (BBF_INTERNAL);
GenTree* asgTree = gtNewAssignNode(gtClone(rtLookupLcl), gtCloneExpr(handleForNullCheck));
Statement* asgStmt = fgNewStmtFromTree(asgTree);
fgInsertStmtAtBeg(fastPathBb, asgStmt);
gtSetStmtInfo(asgStmt);
fgSetStmtSeq(asgStmt);
fastPathBb->bbFlags |= BBF_INTERNAL;
GenTree* asgFastPathValue = gtNewAssignNode(gtClone(rtLookupLcl), gtCloneExpr(handleForNullCheck));
Statement* asgFastPathValueStmt = fgNewStmtFromTree(asgFastPathValue);
fgInsertStmtAtBeg(fastPathBb, asgFastPathValueStmt);
gtSetStmtInfo(asgFastPathValueStmt);
fgSetStmtSeq(asgFastPathValueStmt);

BasicBlock* fallbackBb = fgNewBBafter(BBJ_ALWAYS, nullcheckBb, true);
fallbackBb->bbFlags |= (BBF_INTERNAL);
GenTree* asgTree2 = gtNewAssignNode(gtClone(rtLookupLcl), gtCloneExpr(call));
Statement* asgStmt2 = fgNewStmtFromTree(asgTree2);
fgInsertStmtAtBeg(fallbackBb, asgStmt2);
gtSetStmtInfo(asgStmt2);
fgSetStmtSeq(asgStmt2);
fallbackBb->bbFlags |= BBF_INTERNAL;
GenTree* asgFallbackTree = gtNewAssignNode(gtClone(rtLookupLcl), gtCloneExpr(call));
Statement* asgFallbackStmt = fgNewStmtFromTree(asgFallbackTree);
fgInsertStmtAtBeg(fallbackBb, asgFallbackStmt);
gtSetStmtInfo(asgFallbackStmt);
fgSetStmtSeq(asgFallbackStmt);

// Replace ExpRuntimeLookup call with a local
call->ReplaceWith(gtNewLclvNode(rtLookupLclNum, call->TypeGet()), this);
Expand Down Expand Up @@ -246,7 +246,7 @@ PhaseStatus Compiler::fgExpandRuntimeLookups()
assert(BasicBlock::sameEHRegion(prevBb, nullcheckBb));
assert(BasicBlock::sameEHRegion(prevBb, fastPathBb));

// prevBb = helperCallBb;
prevBb = fastPathBb;
result = PhaseStatus::MODIFIED_EVERYTHING;
goto TRAVERSE_BLOCK_AGAIN;
}
Expand Down