Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use the new BitArray.HasAllSet() method #82057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Use the new BitArray.HasAllSet() method #82057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/libraries/System.Text.Json/src/System/Text/Json/JsonHelpers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,18 +149,19 @@ public static void ValidateInt32MaxArrayLength(uint length)
}
}

public static bool AllBitsEqual(this BitArray bitArray, bool value)
#if !NET8_0_OR_GREATER
public static bool HasAllSet(this BitArray bitArray)
{
// Optimize this when https://github.com/dotnet/runtime/issues/72999 is fixed
for (int i = 0; i < bitArray.Count; i++)
{
if (bitArray[i] != value)
if (!bitArray[i])
{
return false;
}
}

return true;
}
#endif
}
}
2 changes: 1 addition & 1 deletion src/libraries/System.Text.Json/src/System/Text/Json/Serialization/ReadStackFrame.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ internal void ValidateAllRequiredPropertiesAreRead(JsonTypeInfo typeInfo)
{
Debug.Assert(RequiredPropertiesSet != null);

if (!RequiredPropertiesSet.AllBitsEqual(true))
if (!RequiredPropertiesSet.HasAllSet())
{
ThrowHelper.ThrowJsonException_JsonRequiredPropertyMissing(typeInfo, RequiredPropertiesSet);
}
Expand Down