Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[release/6.0] add missing RIDs #82120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 15, 2023
Merged

[release/6.0] add missing RIDs #82120

merged 4 commits into from
Feb 15, 2023

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented Feb 14, 2023

This brings it closer to current main. The changes are

  • macOS 13
  • Android 32
  • Ubuntu 23.04

It is not clear to my why we see big difference in Alpine. It was no touch this tome so perhaps it was not properly generated before.

@ghost
Copy link

ghost commented Feb 14, 2023

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost assigned wfurt Feb 14, 2023
carlossanlop
carlossanlop approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@carlossanlop carlossanlop left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OOB package changes look good. Seems most of the json changes are just sections moved alphabetically. The actual new items are android.32, osx.13 and ubuntu.23.04.

cc @mmitche @rbhanda this is PR 1/2 that we need to wait for. THe other one is for 7.0.

@ghost
Copy link

ghost commented Feb 14, 2023

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

This brings it closer to current main. The changes are

  • macOS 13
  • Android 32
  • Ubuntu 23.04

It is not clear to my why we see big difference in Alpine. It was no touch this tome so perhaps it was not properly generated before.

Author: wfurt
Assignees: wfurt
Labels:

area-Infrastructure
Milestone: -

@wfurt wfurt mentioned this pull request Feb 14, 2023
Merged
@carlossanlop carlossanlop mentioned this pull request Feb 14, 2023
Closed
@carlossanlop
Copy link
Contributor

carlossanlop commented Feb 14, 2023 •
edited
Loading

@wfurt the failures are related to the change. Can you please take a look?

===========================================================================================================

C:\h\w\B0670976\w\A75408EC\e>xunit.console.exe Microsoft.NETCore.Platforms.Tests.dll -xml testResults.xml -nologo -nocolor -notrait category=IgnoreForCI -notrait category=OuterLoop -notrait category=failing  
  Discovering: Microsoft.NETCore.Platforms.Tests (app domain = on [no shadow copy], method display = ClassAndMethod, method display options = None)
  Discovered:  Microsoft.NETCore.Platforms.Tests (found 18 test cases)
  Starting:    Microsoft.NETCore.Platforms.Tests (parallel test collections = on, max threads = 2)
    Microsoft.NETCore.Platforms.BuildTasks.Tests.GenerateRuntimeGraphTests.CanAddArchitectureAndVersionToExistingGroups [FAIL]
      Assert.Equal() Failure
      Expected: RuntimeGraph { Runtimes = [[alpine, (alpine: (#imports: linux-musl); )], [alpine-arm, (alpine-arm: (#imports: alpine,linux-musl-arm); )], [alpine-arm64, (alpine-arm64: (#imports: alpine,linux-musl-arm64); )], [alpine-s390x, (alpine-s390x: (#imports: alpine,linux-musl-s390x); )], [alpine-x64, (alpine-x64: (#imports: alpine,linux-musl-x64); )], ...], Supports = [] }
      Actual:   RuntimeGraph { Runtimes = [[alpine, (alpine: (#imports: linux-musl); )], [alpine-arm, (alpine-arm: (#imports: alpine,linux-musl-arm); )], [alpine-arm64, (alpine-arm64: (#imports: alpine,linux-musl-arm64); )], [alpine-s390x, (alpine-s390x: (#imports: alpine,linux-musl-s390x); )], [alpine-x64, (alpine-x64: (#imports: alpine,linux-musl-x64); )], ...], Supports = [] }
      Stack Trace:
        /_/src/libraries/Microsoft.NETCore.Platforms/tests/GenerateRuntimeGraphTests.cs(120,0): at Microsoft.NETCore.Platforms.BuildTasks.Tests.GenerateRuntimeGraphTests.AssertRuntimeGraphAdditions(String[] additionalRIDs, RuntimeDescription[] expectedAdditions, String additionalRIDParent, String runtimeFilePrefix)
        /_/src/libraries/Microsoft.NETCore.Platforms/tests/GenerateRuntimeGraphTests.cs(220,0): at Microsoft.NETCore.Platforms.BuildTasks.Tests.GenerateRuntimeGraphTests.CanAddArchitectureAndVersionToExistingGroups()
  Finished:    Microsoft.NETCore.Platforms.Tests
=== TEST EXECUTION SUMMARY ===
   Microsoft.NETCore.Platforms.Tests  Total: 102, Errors: 0, Failed: 1, Skipped: 0, Time: 1.740s
----- end Tue 02/14/2023 20:05:57.25 ----- exit code 1 ----------------------------------------------------------

@wfurt
Copy link
Member Author

wfurt commented Feb 14, 2023

let me check.

@carlossanlop carlossanlop mentioned this pull request Feb 14, 2023
Merged
@wfurt
Copy link
Member Author

wfurt commented Feb 14, 2023

it seems like the test was updated as part of #75371
I opportunistically pushed update and I'll do more tests once my full build is done.

@carlossanlop
Copy link
Contributor

CI passed.

@carlossanlop carlossanlop merged commit 6dcd04a into dotnet:release/6.0 Feb 15, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ericstj ericstj Awaiting requested review from ericstj

1 more reviewer

@carlossanlop carlossanlop carlossanlop approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@wfurt wfurt

Labels
area-Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wfurt @carlossanlop