Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Intrinsically recognize Unsafe APIs in the scanner #82589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Intrinsically recognize Unsafe APIs in the scanner #82589

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions src/coreclr/tools/aot/ILCompiler.Compiler/IL/ILImporter.Scanner.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,15 @@ private void ImportCall(ILOpcode opcode, int token)
}
return;
}

if (IsExpandedUnsafeIntrinsic(method))
{
// Size optimization. If we're in shared code, call to an Unsafe intrinsic would bring generic
// lookup for the generic dictionary. We would not be able to get rid of it later.
// To add insult to injury, the dictionary would be empty most of the time.
// RyuJIT recognizes these intrinsically and it's not going to ask for the generic dictionary.
return;
}
}

TypeDesc exactType = method.OwningType;
Expand Down Expand Up @@ -1399,6 +1408,36 @@ private static bool IsEETypePtrOf(MethodDesc method)
return false;
}

private static bool IsExpandedUnsafeIntrinsic(MethodDesc method)
{
if (method.IsIntrinsic && method.OwningType is MetadataType mdType
&& mdType.Name == "Unsafe" && mdType.Namespace == "System.Runtime.CompilerServices")
{
// Unsafe intrinsics RyuJIT expands intrinsically
switch (method.Name)
{
case "Add":
case "AddByteOffset":
case "AreSame":
case "As":
case "AsPointer":
case "AsRef":
case "ByteOffset":
case "IsAddressGreaterThan":
case "IsAddressLessThan":
case "IsNullRef":
case "NullRef":
case "SizeOf":
case "SkipInit":
case "Subtract":
case "SubtractByteOffset":
return true;
}
}

return false;
}

private DefType GetWellKnownType(WellKnownType wellKnownType)
{
return _compilation.TypeSystemContext.GetWellKnownType(wellKnownType);
Expand Down