Implement interfaces in the non-generic enumerator base #82923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...so that the interface implementation details go to the non-generic dispatch map. Saves 1.5 kB on BasicMinimalApi.
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
jkotas
approved these changes
Mar 3, 2023
stephentoub
approved these changes
Mar 3, 2023
This was referenced Mar 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...so that the interface implementation details go to the non-generic dispatch map instead of the individual specialized dispatch maps. Saves 3.5 kB on BasicMinimalApi.
Would be nice if we could do that for
IEnumerableonSZGenericArrayEnumeratorBasebut there's no way to express that in C# (we could express that in IL).