Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add additional close statuses in ManagedWebSocket #83827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 31, 2023
Merged

Add additional close statuses in ManagedWebSocket #83827

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5081756
Allow non RFC close statuses in ManagedWebSocket
IDisposable Mar 23, 2023
e06f810
Cleanup comment format
IDisposable Mar 23, 2023
76f873a
Rename test data to CloseStatuses
IDisposable Mar 27, 2023
4ae46f0
Rename test method to follow naming convention.
IDisposable Mar 27, 2023
8a2cc0a
Addressed PR feedback
IDisposable Mar 27, 2023
e479a56
Rename local for per PR feedback
IDisposable Mar 30, 2023
9e15dec
Label the boolean for isServer flag
IDisposable Mar 30, 2023
e349b33
Use better local variable name
IDisposable Mar 30, 2023
1633968
Address PR and rebase to main
IDisposable Mar 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Rename test data to CloseStatuses 
Co-authored-by: Natalia Kondratyeva <[email protected]>
  • Loading branch information
@IDisposable @CarnaViire
IDisposable and CarnaViire committed Mar 30, 2023
commit 76f873ad5218cadf3598e880f4770e55d1121e99
2 changes: 1 addition & 1 deletion src/libraries/System.Net.WebSockets/tests/WebSocketCloseTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ public WebSocketCloseTests()

public CancellationToken CancellationToken => _cancellation?.Token ?? default;

public static object[][] ClosesData = {
public static object[][] CloseStatuses = {
new object[] { WebSocketCloseStatus.EndpointUnavailable },
new object[] { WebSocketCloseStatus.InternalServerError },
new object[] { WebSocketCloseStatus.InvalidMessageType},
Expand Down