Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[browser][non-icu] HybridGlobalization change case #84019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Apr 4, 2023
Merged

[browser][non-icu] HybridGlobalization change case #84019

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
e9b6ebb
Enabled `HybridGlobalization` mode.
ilonatommy Mar 28, 2023
1fb1e22
Enabled non-icu change case.
ilonatommy Mar 28, 2023
c8e80ee
Tests.
ilonatommy Mar 28, 2023
738c702
Revert not connected changes.
ilonatommy Mar 28, 2023
f397168
Fix: Add the new file to the project.
ilonatommy Mar 28, 2023
d4de126
Fix: this PR is for Browser, so add it to condition.
ilonatommy Mar 28, 2023
7a1b55c
Fixed calls to js.
ilonatommy Mar 28, 2023
30c7039
Trying to fix CI.
ilonatommy Mar 28, 2023
f6f9fcf
False is default, redundant lines.
ilonatommy Mar 28, 2023
a8ef060
Trying to fix the CI.
ilonatommy Mar 28, 2023
76abac8
Remove redundant code.
ilonatommy Mar 28, 2023
376d12d
This PR is partial solution, this file will be added in a follow-up.
ilonatommy Mar 28, 2023
ceee24a
Fix for EAT lib tests.
ilonatommy Mar 29, 2023
9afe416
We do not trim anything for Hybrid currently.
ilonatommy Mar 29, 2023
4349310
Check if functions invoked only in specific modes.
ilonatommy Mar 30, 2023
ab8fb10
Change confusing name + move the common property to the main part of …
ilonatommy Mar 30, 2023
89cbb73
Applied @mkhamoyan's suggestion.
ilonatommy Mar 30, 2023
de57dec
Fix previous commit: missing directive.
ilonatommy Mar 30, 2023
9066e11
Fix previous commit: missing directive.
ilonatommy Mar 30, 2023
1d15645
It's not IOS-connected.
ilonatommy Mar 30, 2023
52935e3
Merge branch 'main' into hg-change-case
ilonatommy Mar 30, 2023
c082aea
Move hybrid tests to correct dir + separate ios and wasm + update sln.
ilonatommy Mar 31, 2023
1f8d4f9
Invariant and hybrid cannot be both true.
ilonatommy Mar 31, 2023
1aea9a8
Remove old version of hybrid tests proj.
ilonatommy Mar 31, 2023
ef626b4
Applied @kg's review.
ilonatommy Apr 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix previous commit: missing directive.
  • Loading branch information
@ilonatommy
ilonatommy committed Mar 30, 2023
commit de57dec17f6e6edf6b9b2df918abbdbea964fb74
2 changes: 2 additions & 0 deletions src/libraries/System.Private.CoreLib/src/System/Globalization/TextInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -686,11 +686,13 @@ private unsafe void ChangeCaseCore(char* src, int srcLen, char* dstBuffer, int d
NlsChangeCase(src, srcLen, dstBuffer, dstBufferCapacity, bToUpper);
return;
}
#if TARGET_OSX || TARGET_MACCATALYST || TARGET_IOS || TARGET_TVOS || TARGET_BROWSER || TARGET_WASI
if (GlobalizationMode.Hybrid)
{
JsChangeCase(src, srcLen, dstBuffer, dstBufferCapacity, bToUpper);
return;
}
#endif
IcuChangeCase(src, srcLen, dstBuffer, dstBufferCapacity, bToUpper);
}

Expand Down