Fix a number of issues related to boxed value serialization #84768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g an explicit `Type` parameter.
…t supply metadata for `object`.
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsThis PR:
I've split up the PR into three separate commits for easier reviewing.
|
eiriktsarpalis
commented
Apr 13, 2023
...aries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/UnspeakableTypeTests.cs
Show resolved
Hide resolved
Sergio0694
reviewed
Apr 13, 2023
...ries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/PolymorphicTypeResolver.cs
Show resolved
Hide resolved
eerhardt
reviewed
Apr 14, 2023
...ies/System.Text.Json/src/System/Text/Json/Serialization/Converters/Object/ObjectConverter.cs
Outdated
Show resolved
Hide resolved
...ries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/PolymorphicTypeResolver.cs
Show resolved
Hide resolved
...ries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/PolymorphicTypeResolver.cs
Show resolved
Hide resolved
...braries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializerOptions.Caching.cs
Outdated
Show resolved
Hide resolved
tarekgh
approved these changes
Apr 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Typeparameter. Unspeakable type support now only works for values that are serialized asobjecttypes. Fix Add source gen support forunspeakable types#82457.object. Fix JSON Serialize as object doesn't work with source generation by default #84704.I've split up the PR into three separate commits for easier reviewing.