Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Avoid unnecessary array allocation in DateTimeParse #84964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2023
Merged

Avoid unnecessary array allocation in DateTimeParse #84964

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/System.Private.CoreLib/src/System/Globalization/DateTimeFormatInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1204,7 +1204,7 @@ internal string InternalGetMonthName(int month, MonthNameStyles style, bool abbr
/// Retrieve the array which contains the month names in genitive form.
/// If this culture does not use the genitive form, the normal month name is returned.
/// </summary>
private string[] InternalGetGenitiveMonthNames(bool abbreviated)
internal string[] InternalGetGenitiveMonthNames(bool abbreviated)
{
if (abbreviated)
{
Expand Down
4 changes: 2 additions & 2 deletions src/libraries/System.Private.CoreLib/src/System/Globalization/DateTimeParse.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3353,7 +3353,7 @@ private static bool MatchAbbreviatedMonthName(ref __DTString str, DateTimeFormat
// Search genitive form.
if ((dtfi.FormatFlags & DateTimeFormatFlags.UseGenitiveMonth) != 0)
{
int tempResult = str.MatchLongestWords(dtfi.AbbreviatedMonthGenitiveNames, ref maxMatchStrLen);
int tempResult = str.MatchLongestWords(dtfi.InternalGetGenitiveMonthNames(abbreviated: true), ref maxMatchStrLen);

// We found a longer match in the genitive month name. Use this as the result.
// tempResult + 1 should be the month value.
Expand Down Expand Up @@ -3453,7 +3453,7 @@ private static bool MatchMonthName(ref __DTString str, DateTimeFormatInfo dtfi,
// Search genitive form.
if ((dtfi.FormatFlags & DateTimeFormatFlags.UseGenitiveMonth) != 0)
{
int tempResult = str.MatchLongestWords(dtfi.MonthGenitiveNames, ref maxMatchStrLen);
int tempResult = str.MatchLongestWords(dtfi.InternalGetGenitiveMonthNames(abbreviated: false), ref maxMatchStrLen);
// We found a longer match in the genitive month name. Use this as the result.
// The result from MatchLongestWords is 0 ~ length of word array.
// So we increment the result by one to become the month value.
Expand Down