Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[browser][non-icu] HybridGlobalization indexing #85254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
May 18, 2023
Merged

[browser][non-icu] HybridGlobalization indexing #85254

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
4972ff5
A bit faster version of indexing. WIP
ilonatommy Apr 22, 2023
c530176
Tiny speedup.
ilonatommy Apr 24, 2023
e04620f
Fixed IndexOf, ToDo: LastIndexOf.
ilonatommy Apr 25, 2023
2ef45d5
All tests pass.
ilonatommy Apr 25, 2023
fedfc99
Updated docs.
ilonatommy Apr 25, 2023
ad59404
Update docs.
ilonatommy Apr 26, 2023
836ab06
Slicing + saving previous absolute index instead of pushing the itera…
ilonatommy Apr 26, 2023
a903c74
Refactored.
ilonatommy Apr 26, 2023
0972293
Merge branch 'main' into hg-indexing-faster
ilonatommy Apr 26, 2023
3758a6d
Fixed tests on browser.
ilonatommy Apr 26, 2023
7eb6c87
Str1 and str2 was confusing.
ilonatommy Apr 27, 2023
2dd48b1
Merge branch 'main' into hg-indexing-faster
ilonatommy Apr 27, 2023
21df176
Merge branch 'main' into hg-indexing-faster
ilonatommy May 2, 2023
9efd522
Fix CI- correctly trimming Hybrid properties.
ilonatommy May 3, 2023
c6c6849
Previous commit should target only Browser.
ilonatommy May 4, 2023
4f0d230
Applied @mkhamoyan's suggestion to avoid code duplication.
ilonatommy May 11, 2023
4732927
Merge branch 'main' into hg-indexing-faster
ilonatommy May 11, 2023
2e676cc
Merge branch 'main' into hg-indexing-faster
ilonatommy May 12, 2023
583d526
Applied @pavel's review.
ilonatommy May 17, 2023
2b9fe34
Get rid of build errors.
ilonatommy May 17, 2023
9775256
Revert.
ilonatommy May 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Previous commit should target only Browser.
  • Loading branch information
@ilonatommy
ilonatommy committed May 4, 2023
commit c6c68492b2e3f29bd06e67e6789907275017d62f
7 changes: 7 additions & 0 deletions src/libraries/System.Private.CoreLib/src/ILLink/ILLink.Substitutions.Browser.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<linker>
<assembly fullname="System.Private.CoreLib">
<type fullname="System.Globalization.GlobalizationMode">
<method signature="System.Boolean get_Hybrid()" body="stub" value="true" feature="System.Globalization.Hybrid" featurevalue="false" />
</type>
</assembly>
</linker>
1 change: 0 additions & 1 deletion src/libraries/System.Private.CoreLib/src/ILLink/ILLink.Substitutions.Shared.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
<!-- Note: Invariant=true and Invariant=false are substituted at different levels. This allows for the whole Settings nested class
to be trimmed when Invariant=true, and allows for the Settings static cctor (on Unix) to be preserved when Invariant=false. -->
<type fullname="System.Globalization.GlobalizationMode">
<method signature="System.Boolean get_Hybrid()" body="stub" value="true" feature="System.Globalization.Hybrid" featurevalue="false" />
<method signature="System.Boolean get_Invariant()" body="stub" value="true" feature="System.Globalization.Invariant" featurevalue="true" />
<method signature="System.Boolean get_PredefinedCulturesOnly()" body="stub" value="true" feature="System.Globalization.PredefinedCulturesOnly" featurevalue="true" />
</type>
Expand Down
1 change: 1 addition & 0 deletions src/libraries/System.Private.CoreLib/src/System.Private.CoreLib.Shared.projitems
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@
<ILLinkSubstitutionsXmls Include="$(ILLinkSharedDirectory)ILLink.Substitutions.NoArmIntrinsics.xml" Condition="'$(SupportsArmIntrinsics)' != 'true'" />
<ILLinkSubstitutionsXmls Include="$(ILLinkSharedDirectory)ILLink.Substitutions.NoX86Intrinsics.xml" Condition="'$(SupportsX86Intrinsics)' != 'true'" />
<ILLinkSubstitutionsXmls Include="$(ILLinkSharedDirectory)ILLink.Substitutions.OSX.xml" Condition="'$(IsOSXLike)' == 'true'" />
<ILLinkSubstitutionsXmls Include="$(ILLinkSharedDirectory)ILLink.Substitutions.Browser.xml" Condition="'$(TargetsBrowser)' == 'true'" />
<ILLinkLinkAttributesXmls Include="$(ILLinkSharedDirectory)ILLink.LinkAttributes.Shared.xml" />
</ItemGroup>
<PropertyGroup>
Expand Down